Skip to content

Commit e60b5c7

Browse files
committed
Minor test fixes
1 parent c5b8f3d commit e60b5c7

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/SIL.XForge.Scripture/ClientApp/src/app/core/text-doc.service.spec.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ describe('TextDocService', () => {
8080
it('should return true if the project and user are correctly configured', () => {
8181
const env = new TestEnvironment();
8282
const project = createTestProjectProfile({
83-
editingRequires: EditingRequires.ParatextEditingEnabled | EditingRequires.ViewModelBlankSupport,
8483
sync: { dataInSync: true },
8584
texts: [
8685
{ bookNum: 1, chapters: [{ number: 1, isValid: true, permissions: { user01: TextInfoPermission.Write } }] }
@@ -106,7 +105,6 @@ describe('TextDocService', () => {
106105
it('should return false if user does not have general edit right', () => {
107106
const env = new TestEnvironment();
108107
const project = createTestProjectProfile({
109-
editingRequires: EditingRequires.ParatextEditingEnabled | EditingRequires.ViewModelBlankSupport,
110108
sync: { dataInSync: true },
111109
texts: [
112110
{ bookNum: 1, chapters: [{ number: 1, isValid: true, permissions: { user01: TextInfoPermission.Write } }] }
@@ -122,7 +120,6 @@ describe('TextDocService', () => {
122120
it('should return false if user does not have chapter edit permission', () => {
123121
const env = new TestEnvironment();
124122
const project = createTestProjectProfile({
125-
editingRequires: EditingRequires.ParatextEditingEnabled | EditingRequires.ViewModelBlankSupport,
126123
sync: { dataInSync: true },
127124
texts: [
128125
{ bookNum: 1, chapters: [{ number: 1, isValid: true, permissions: { user01: TextInfoPermission.Read } }] }
@@ -138,7 +135,6 @@ describe('TextDocService', () => {
138135
it('should return false if data is not in sync', () => {
139136
const env = new TestEnvironment();
140137
const project = createTestProjectProfile({
141-
editingRequires: EditingRequires.ParatextEditingEnabled | EditingRequires.ViewModelBlankSupport,
142138
sync: { dataInSync: false },
143139
texts: [
144140
{ bookNum: 1, chapters: [{ number: 1, isValid: true, permissions: { user01: TextInfoPermission.Write } }] }
@@ -170,7 +166,6 @@ describe('TextDocService', () => {
170166
it('should return true if all conditions are met', () => {
171167
const env = new TestEnvironment();
172168
const project = createTestProjectProfile({
173-
editingRequires: EditingRequires.ParatextEditingEnabled | EditingRequires.ViewModelBlankSupport,
174169
sync: { dataInSync: true },
175170
texts: [
176171
{ bookNum: 1, chapters: [{ number: 1, isValid: true, permissions: { user01: TextInfoPermission.Write } }] }
@@ -242,9 +237,7 @@ describe('TextDocService', () => {
242237

243238
it('should return false if the project is editable', () => {
244239
const env = new TestEnvironment();
245-
const project = createTestProjectProfile({
246-
editingRequires: EditingRequires.ParatextEditingEnabled | EditingRequires.ViewModelBlankSupport
247-
});
240+
const project = createTestProjectProfile();
248241

249242
// SUT
250243
const actual: boolean = env.textDocService.isEditingDisabled(project);
@@ -260,7 +253,7 @@ describe('TextDocService', () => {
260253
expect(actual).toBe(true);
261254
});
262255

263-
it('should return true if the project is has been upgraded to a version beyond the supported version', () => {
256+
it('should return true if the project has been upgraded to a version beyond the supported version', () => {
264257
const env = new TestEnvironment();
265258
const project = createTestProjectProfile({
266259
editingRequires: Number.MAX_SAFE_INTEGER
@@ -271,7 +264,7 @@ describe('TextDocService', () => {
271264
expect(actual).toBe(true);
272265
});
273266

274-
it('should return true if the project is has not been upgraded to view model support', () => {
267+
it('should return true if the project has not been upgraded to view model support', () => {
275268
const env = new TestEnvironment();
276269
const project = createTestProjectProfile({
277270
editingRequires: EditingRequires.ParatextEditingEnabled

src/SIL.XForge.Scripture/ClientApp/src/app/shared/test-utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ export function getEmptyChapterDoc(id: TextDocId, modelHasBlanks: boolean): Text
163163
if (modelHasBlanks) delta.insert({ blank: true }, { segment: 'p_2' });
164164
delta.insert({ verse: { number: '3', style: 'v' } });
165165
if (modelHasBlanks) delta.insert({ blank: true }, { segment: 'verse_1_3' });
166+
// The double \n represents the blank segments for verse_1_3 and p_2
166167
delta.insert('\n\n', { para: { style: 'p' } });
167168
return delta;
168169
}

0 commit comments

Comments
 (0)