Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and document using of php private static extensions #186

Open
emteknetnz opened this issue Jan 22, 2024 · 0 comments
Open

Validate and document using of php private static extensions #186

emteknetnz opened this issue Jan 22, 2024 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 22, 2024

There are two ways to define Silverstripe config

  • yaml
  • private static $extensions

Based on this comment

extension config that is inherently necessary for a class to function as expected should be in the class itself.
e.g. SiteTree is always expected to be versioned, so we have the versioned extension declared in the class directly. This implies those extensions should never be removed - whereas extensions added via yaml should be allowed to be removed without negative impacts.

We should:

  • Validate the any existing non-optional config is declared in php extensions and composer requirements if necessary
  • Update documentation that makes it clear when to use each type of config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant