Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heatmap] Dark mode inverts colormap #52

Closed
loichuder opened this issue Sep 1, 2021 · 2 comments · Fixed by #60
Closed

[Heatmap] Dark mode inverts colormap #52

loichuder opened this issue Sep 1, 2021 · 2 comments · Fixed by #60
Labels
bug Something isn't working

Comments

@loichuder
Copy link
Member

loichuder commented Sep 1, 2021

Settings > JupyterLab Theme > JupyterLab Light
image

All is well.

Settings > JupyterLab Theme > JupyterLab Dark
image

Heatmap, color map and color bar are inverted.

@loichuder loichuder added the bug Something isn't working label Sep 1, 2021
@loichuder
Copy link
Member Author

Already reported in #34 in fact

@axelboc
Copy link
Contributor

axelboc commented Sep 9, 2021

Hmm, maybe the selector body[data-jp-theme-light='false'] .h5web-root is outdated?

body[data-jp-theme-light='false'] .h5web-root {
  filter: invert();

  /* Set shadows to lighter colors so they remain dark once inverted */
  --btn-shadow-color: #f5f5f5;
  --btn-shadow-dark-color: #fafafa;
  --btn-shadow-darker-color: #fff;
}

body[data-jp-theme-light='false'] .h5web-root .no-invert,
body[data-jp-theme-light='false'] .h5web-root .no-invert-canvas > canvas {
  filter: invert(); /* invert back to normal colors */
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants