prefer-array-index-of.md

Prefer Array#{indexOf,lastIndexOf}() over Array#{findIndex,findLastIndex}() when looking for the index of an item

💼 This rule is enabled in the ✅ recommended config.

🔧💡 This rule is automatically fixable by the --fix CLI option and manually fixable by editor suggestions.

Array#findIndex() and Array#findLastIndex() are intended for more complex needs. If you are just looking for the index where the given item is present, then the code can be simplified to use Array#indexOf() or Array#lastIndexOf() . This applies to any search with a literal, a variable, or any expression that doesn't have any explicit side effects. However, if the expression you are looking for relies on an item related to the function (its arguments, the function self, etc.), the case is still valid.

This rule is fixable, unless the search expression has side effects.

Fail

const index = foo.findIndex(x => x === 'foo');

const index = foo.findIndex(x => 'foo' === x);

const index = foo.findIndex(x => {
	return x === 'foo';
});

const index = foo.findLastIndex(x => x === 'foo');

const index = foo.findLastIndex(x => 'foo' === x);

const index = foo.findLastIndex(x => {
	return x === 'foo';
});

Pass

const index = foo.indexOf('foo');

const index = foo.findIndex(x => x == undefined);

const index = foo.findIndex(x => x !== 'foo');

const index = foo.findIndex((x, index) => x === index);

const index = foo.findIndex(x => (x === 'foo') && isValid());

const index = foo.findIndex(x => y === 'foo');

const index = foo.findIndex(x => y.x === 'foo');

const index = foo.findIndex(x => {
	const bar = getBar();
	return x === bar;
});

const index = foo.lastIndexOf('foo');

const index = foo.findLastIndex(x => x == undefined);

const index = foo.findLastIndex(x => x !== 'foo');

const index = foo.findLastIndex((x, index) => x === index);

const index = foo.findLastIndex(x => (x === 'foo') && isValid());

const index = foo.findLastIndex(x => y === 'foo');

const index = foo.findLastIndex(x => y.x === 'foo');

const index = foo.findLastIndex(x => {
	const bar = getBar();
	return x === bar;
});