Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow publishConfig.registry to be npm default registry #749

Closed
fisker opened this issue Jun 29, 2024 · 2 comments · Fixed by #750
Closed

Allow publishConfig.registry to be npm default registry #749

fisker opened this issue Jun 29, 2024 · 2 comments · Fixed by #750

Comments

@fisker
Copy link
Contributor

fisker commented Jun 29, 2024 •
edited
Loading

Description

I have

  "publishConfig": {
    "access": "public",
    "registry": "https://registry.npmjs.org/"
  }

in all my packages. When using yarn berry, np throws a error,

External registry is not yet supported with yarn-berry

Steps to reproduce

  1. Add the publishConfig above to package.json
  2. Run yarn set version berry
  3. Run np

Expected behavior

Not throw errors.

Environment

np - 10.0.6
Node.js - 22
npm - Should not releated
Git - Should not releated
OS - Should not releated

Related code

np/source/npm/util.js

Line 46 in a9e8fc7

export const isExternalRegistry = package_ => typeof package_.publishConfig?.registry === 'string';

@sindresorhus
Copy link
Owner

// @mifi

@fisker fisker changed the title It's allow publishConfig.registry to be npm default registry Allow publishConfig.registry to be npm default registry Jun 29, 2024
@mifi
Copy link
Contributor

mifi commented Jul 1, 2024

Yeah I didn't implement support for that when I added berry support. Feel free to submit a PR if there's an easy way to add support for it.

This was referenced Jul 16, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow publishConfig.registry to be npm default registry when using Yarn berry fisker/np
3 participants
@sindresorhus @fisker @mifi