Joao/deck2 templates #535
Open
Joao/deck2 templates #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into joao/deck2-templates "fix: templates by gender"
Francisca105
requested changes
Nov 24, 2025
| palestra no nosso evento. Ficaríamos muito gratos pela | ||
| oportunidade de recebê-l<b style="color: red">o/a/e</b> se | ||
| aceitar este convite. | ||
| Sou {{.MemberArticle}} {{.Member}}, um orgulhoso membro da |
Member
There was a problem hiding this comment.
"um orgulhoso membro" also needs the article
| const createSpeakerTemplateVariables = () => { | ||
| const endDate = new Date(eventStore.selectedEvent?.end || 0); | ||
| const memberGender = authStore.member?.contactObject?.gender ?? "OTHER"; |
Member
There was a problem hiding this comment.
The idea is to force the user to fill all the information. The gender of the member and the speaker should always exist when getting to this step.
| return { article: "o", suffix: "" }; | ||
| case "FEMALE": | ||
| return { article: "a", suffix: "a" }; | ||
| default: |
Member
There was a problem hiding this comment.
it misses the "OTHER" gender case
Author
There was a problem hiding this comment.
wouldn't the default case and the "OTHER" case be the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.