-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create V3 #6
Comments
sinmetal
added a commit
that referenced
this issue
Mar 7, 2022
Merged
sinmetal
added a commit
that referenced
this issue
Mar 7, 2022
sinmetal
added a commit
that referenced
this issue
Mar 8, 2022
resizeHandler作ってて、ちょっと使いづらいなと思った部分を修正した
sinmetal
added a commit
that referenced
this issue
Mar 9, 2022
sinmetal
added a commit
that referenced
this issue
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
じわじわ知見がたまり、インターフェースを変えたい部分も増えてきたので、V3を作成する
ImageHandlerの削除
サンプルもかねて用意していたが、そのまま使うとキャッシュのロジック変えたい時とかに不便なので、あくまでExample程度にしておくのがよさそうという気持ちになった
"golang.org/x/xerrors" をerrorsに変更
標準に入ったので移行しよう
ReadAndWriteWithoutResize をsingleflightしやすいように変更する
呼べばいいだけにするように多くの機能をこの中に入れているが、singleflightしたりキャッシュしたりする場合、機能が中に入りすぎてやりづらいのでこれをばらしていく
The text was updated successfully, but these errors were encountered: