From bc22847beaa1e5211cfea8394f4da3db1ef6997b Mon Sep 17 00:00:00 2001 From: Siddharth Suresh Date: Wed, 24 Jun 2026 23:06:56 -0700 Subject: [PATCH 1/2] =?UTF-8?q?SPIKE:=20Protocol=2028=20(CAP-0084)=20?= =?UTF-8?q?=E2=80=94=20track=20js-stellar-base=20bump=20+=20browser-bundle?= =?UTF-8?q?=20rebuild?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CAP-0084 (Muxed Contract Addresses) adds a new SCAddress arm SC_ADDRESS_TYPE_MUXED_CONTRACT=5 with struct MuxedContract { uint64 id; ContractID contractId; }, gated behind the CAP_0084 XDR feature flag. Canonical XDR head: stellar/stellar-xdr @ 2769fed744c4ec5a2cf6581addfc1704abfcba7c (#305). js-stellar-sdk has NO XDR of its own and NO CAP feature-flag config: it re-exports everything (including `xdr`) from @stellar/stellar-base (src/index.ts: `export * from "@stellar/stellar-base"`). So the only SDK-side work for CAP-0084 is to consume a CAP-0084-patched stellar-base and rebuild the shipped artifacts. This commit re-points the dependency from the 15.0.0 release to the CAP-0084 js-stellar-base fork branch, mirroring the cap-71-p27 spike: "@stellar/stellar-base": "github:sisuresh/js-stellar-base#p28-cap-0084" DEFERRED (cannot run yet — the CAP-0084 js-stellar-base is being regenerated in a sibling branch and is not yet published/buildable): - Install + regenerate lockfile against the new base: yarn install - Rebuild node + browser bundles (the browser bundle embeds stellar-base's generated XDR at build time; without this rebuild the SDK ships STALE XDR and the SC_ADDRESS_TYPE_MUXED_CONTRACT arm will be missing from dist/): yarn build:prod # = build:node:all + build:browser:all or just the browser bundle: yarn build:browser:all - For a real PR (not a fork-branch ref), bump to the published CAP-0084 stellar-base version, e.g. "@stellar/stellar-base": "^15.x.0". - tsc may surface implicit-any regressions from the regenerated base types (same as cap-71-p27); resolve before merge. dist/ and lib/ are gitignored, so no bundle artifacts are committed here; they must be produced by the build commands above once the dependency is available. DO NOT fabricate them. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a53b8de6b..ceb13ee03 100644 --- a/package.json +++ b/package.json @@ -199,7 +199,7 @@ "webpack-cli": "^5.0.1" }, "dependencies": { - "@stellar/stellar-base": "^15.0.0", + "@stellar/stellar-base": "github:sisuresh/js-stellar-base#p28-cap-0084", "axios": "1.15.0", "bignumber.js": "^9.3.1", "commander": "^14.0.3", From a614429956da5ecf57f30b7f1dc08e77a8525510 Mon Sep 17 00:00:00 2001 From: Siddharth Suresh Date: Thu, 25 Jun 2026 02:26:44 -0700 Subject: [PATCH 2/2] build: regenerate yarn.lock against CAP-0084 stellar-base fork Re-resolves @stellar/stellar-base to the github fork branch (sisuresh/js-stellar-base#p28-cap-0084, tarball daec58d). Only the stellar-base entry changes; transitive deps are unchanged. Build verified locally with 'yarn build:prod': node lib/ re-exports the CAP-0084 SC_ADDRESS_TYPE_MUXED_CONTRACT arm (xdr.ScAddressType .scAddressTypeMuxedContract) and the browser bundle dist/stellar-sdk.min.js embeds it. dist/ and lib/ are gitignored, so no bundle artifacts are committed. Note: env node 22.5.1 is below the 22.13.0 floor required by a transitive devDep (eslint-visitor-keys@5.0.1), so local install/build needs 'yarn install --ignore-engines'; CI on node >=22.13 is unaffected. --- yarn.lock | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index a087b0aaf..7e0820a9c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1448,10 +1448,9 @@ resolved "https://registry.yarnpkg.com/@stellar/js-xdr/-/js-xdr-4.0.0.tgz#5c4bd396a71ea3aef7a91dee885cf8dd2e10c5cf" integrity sha512-+NmNa7Tk5BI5XFdy/6xGTqAN4J9a9KgCrCGhj2uEUTCBhLkch0M+QbKzNH8zEnejWe0p8w+0q5hUVX6L3OzoVA== -"@stellar/stellar-base@^15.0.0": +"@stellar/stellar-base@github:sisuresh/js-stellar-base#p28-cap-0084": version "15.0.0" - resolved "https://registry.yarnpkg.com/@stellar/stellar-base/-/stellar-base-15.0.0.tgz#431537f168f37e606d6a0f0dc026516914718e1f" - integrity sha512-XQhxUr9BYiEcFcgc4oWcCMR9QJCny/GmmGsuwPKf/ieIcOeb5149KLHYx9mJCA0ea8QbucR2/GzV58QbXOTxQA== + resolved "https://codeload.github.com/sisuresh/js-stellar-base/tar.gz/daec58df3040dbbd2b7a58a7bd5bb90c653d562d" dependencies: "@noble/curves" "^1.9.7" "@stellar/js-xdr" "^4.0.0"