Skip to content
This repository was archived by the owner on Jun 5, 2019. It is now read-only.
This repository was archived by the owner on Jun 5, 2019. It is now read-only.

Script "clean" fails on windows #120

Open
@skairunner

Description

@skairunner

The rm command line utility does not exist on Windows, so all scripts that require "clean" fail on Windows.

Activity

skairunner

skairunner commented on Mar 19, 2018

@skairunner
Author

Related, compile fails with the following error:

'NODE_ENV' is not recognized as an internal or external command,
operable program or batch file.

Another Windows batch difference, I imagine.

skellock

skellock commented on Mar 19, 2018

@skellock
Owner

For the first issue, I've seen people use yarn add --dev rimraf and yarn add --dev trash to get around that. If you're feeling up for a PR, that'd be sweet.

For the 2nd issue, I'm not sure how windows sets their environment variables. hmmm... I'll have to look into that one. Unless you know?

skairunner

skairunner commented on Mar 19, 2018

@skairunner
Author

SET NODE_ENV=[whatever], I believe. I'm not sure how you would change the script to figure out when it's on windows vs a POSIX-y system, tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @skellock@skairunner

        Issue actions

          Script "clean" fails on windows · Issue #120 · skellock/typescript-with-electron-react-kit