From 727143cdcfe798d2fdce17979c8b4872f5adab49 Mon Sep 17 00:00:00 2001 From: Haksung Jang Date: Tue, 14 Jul 2026 13:13:13 +0900 Subject: [PATCH] fix(desktop): load logo assets via relative paths so the packaged app renders MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The logo PR referenced /favicon.svg and /logo-mark.svg with absolute paths. Vite's base is './' precisely so the packaged app can load assets over file:// (Electron loadFile); an absolute '/' resolves to the drive root instead, so both assets 404 with ERR_FILE_NOT_FOUND in the built app — the favicon and the in-app header logo never appear, and the file:// render E2E (file-load.e2e.mjs) fails. - App.tsx: import the header mark from src/assets so Vite inlines it (779 B → data URI) instead of a runtime absolute URL - index.html: reference the favicon relatively (favicon.svg) - move logo-mark.svg into src/assets; drop the unused public/logo.svg Verified: frontend build + file-load.e2e.mjs pass locally. --- frontend/index.html | 2 +- frontend/public/logo.svg | 18 ------------------ frontend/src/App.tsx | 3 ++- frontend/{public => src/assets}/logo-mark.svg | 0 4 files changed, 3 insertions(+), 20 deletions(-) delete mode 100644 frontend/public/logo.svg rename frontend/{public => src/assets}/logo-mark.svg (100%) diff --git a/frontend/index.html b/frontend/index.html index 2d9dca1..8c571c1 100644 --- a/frontend/index.html +++ b/frontend/index.html @@ -3,7 +3,7 @@ - + onot — OSS Notice Generator diff --git a/frontend/public/logo.svg b/frontend/public/logo.svg deleted file mode 100644 index 294f588..0000000 --- a/frontend/public/logo.svg +++ /dev/null @@ -1,18 +0,0 @@ - - - - - - - - - - - - - - - - onot - OSS NOTICE GENERATOR - diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx index ed8b072..0ba7462 100644 --- a/frontend/src/App.tsx +++ b/frontend/src/App.tsx @@ -1,4 +1,5 @@ import { useState } from "react"; +import logoMark from "./assets/logo-mark.svg"; import sampleSpdx from "./assets/example.spdx.json?raw"; import { FileDropzone } from "./components/FileDropzone"; import { Preview } from "./components/Preview"; @@ -112,7 +113,7 @@ export default function App() { return (
- onot + onot

{t(uiLang, "title")}

{t(uiLang, "subtitle")}

diff --git a/frontend/public/logo-mark.svg b/frontend/src/assets/logo-mark.svg similarity index 100% rename from frontend/public/logo-mark.svg rename to frontend/src/assets/logo-mark.svg