You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of different classes seems to be using devices in a fashion that I can say is complex and users have no control exactly on how they can easily switch between devices.
Like here the device being used is the one of the input which is somehow complex for the interface being used.
I suggest the Introduction of the device parameter to the classes. This would give users control over the device control and switching, rather than relying entirely on input data devices.
The text was updated successfully, but these errors were encountered:
This is the tuning code, I think it's extraneous to the models - as long as the models themselves have it not hard-coded, I consider this less of a problem. I feel this one tuning routine does a lot of hard-coding and things extraneous to an otherwise very consistent architectural design.
Expected behavior
The current implementation of different classes seems to be using devices in a fashion that I can say is complex and users have no control exactly on how they can easily switch between devices.
https://github.com/jdb78/pytorch-forecasting/blob/81aee6650ed3de0c3071c9ce1fce19eec7fc24a7/pytorch_forecasting/metrics/distributions.py#L470
Like here the device being used is the one of the input which is somehow complex for the interface being used.
I suggest the Introduction of the device parameter to the classes. This would give users control over the device control and switching, rather than relying entirely on input data devices.
The text was updated successfully, but these errors were encountered: