Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule is not tagged properly #2449

Open
HappyHacker123 opened this issue Sep 3, 2024 · 1 comment
Open

Submodule is not tagged properly #2449

HappyHacker123 opened this issue Sep 3, 2024 · 1 comment

Comments

@HappyHacker123
Copy link

HappyHacker123 commented Sep 3, 2024

I found that module github.com/skydive-project/skydive/graffiti is a submodule of skydive.

However, it seems that submodule github.com/skydive-project/skydive/graffiti is not tagged. According to Go Modules standard , submodule should be tagged like relative-path-to-root/vX.X.X.
At present, when trying to import the package, downstream project would have to depend on pseudo-version of it and cannot get a valid tag version.

require github.com/skydive-project/skydive/graffiti v0.0.0-20240717134610-a4452f214754

Would you consider tagging the submodule according to Go standard, for example, releasing a tag `graffiti/v0.28.0``, so that we can use tag version to import this module in go.mod?

@HappyHacker123
Copy link
Author

@lebauce Could you please take a look at this issue? Many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant