test: trim test_payload_utils to new-behavior tests only

The characterization tests for the pre-existing assistant predicates,
and the shared scenario fixture improvements, were moved to a separate
branch (PR #1548) so they can land on main first as a regression net.

This branch now keeps only the tests for behavior it introduces: the
new is_message_event, is_any_im_message_event, and is_im_message_event
predicates.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>

Author: WilliamBergamin

tests/slack_bolt/request/test_payload_utils.py

@@ -1,14 +1,7 @@
 from slack_bolt.request.payload_utils import (
-    is_event,
     is_message_event,
     is_any_im_message_event,
     is_im_message_event,
-    is_user_message_event_in_assistant_thread,
-    is_bot_message_event_in_assistant_thread,
-    is_other_message_sub_event_in_assistant_thread,
-    is_assistant_event,
-    is_assistant_thread_started_event,
-    is_assistant_thread_context_changed_event,
 )
 from tests.scenario_tests.test_events_assistant import (
     build_payload,
@@ -114,33 +107,6 @@
 
 
 class TestPayloadUtils:
-    def test_is_event(self):
-        positives = {
-            "thread_started": thread_started_event_body,
-            "thread_context_changed": thread_context_changed_event_body,
-            "user_message_im": user_message_event_body,
-            "user_message_im_with_assistant_thread": user_message_event_body_with_assistant_thread,
-            "message_changed_im": message_changed_event_body,
-            "channel_user_message": channel_user_message_event_body,
-            "channel_message_changed": channel_message_changed_event_body,
-            "bot_message_channel": bot_message_event_payload,
-            "classic_bot_message_channel": classic_bot_message_event_payload,
-            "message_deleted_channel": message_deleted_channel_body,
-            "reaction_added": reaction_added_event_body,
-            "file_share_im": file_share_im_message_body,
-            "bot_im_thread": bot_im_thread_message_body,
-            "im_no_thread_ts": im_message_no_thread_ts_body,
-        }
-        negatives = {
-            "block_actions": block_actions_body,
-            "slash_command": slash_command_body,
-            "empty_dict": {},
-        }
-        for key, body in positives.items():
-            assert is_event(body), f"{key} should be recognized as an event"
-        for key, body in negatives.items():
-            assert not is_event(body), f"{key} should NOT be recognized as an event"
-
     def test_is_message_event(self):
         positives = {
             "user_message_im": user_message_event_body,
@@ -219,151 +185,3 @@ def test_is_im_message_event(self):
             assert is_im_message_event(body), f"{key} should pass {is_im_message_event.__name__}"
         for key, body in negatives.items():
             assert not is_im_message_event(body), f"{key} should NOT pass {is_im_message_event.__name__}"
-
-    def test_is_user_message_event_in_assistant_thread(self):
-        # Requires: is_im_message_event + thread_ts present + bot_id absent
-        positives = {
-            "user_message_im": user_message_event_body,
-            "user_message_im_with_assistant_thread": user_message_event_body_with_assistant_thread,
-            "file_share_im": file_share_im_message_body,
-        }
-        negatives = {
-            "bot_im_thread": bot_im_thread_message_body,
-            "im_no_thread_ts": im_message_no_thread_ts_body,
-            "message_changed_im": message_changed_event_body,
-            "channel_user_message": channel_user_message_event_body,
-            "channel_message_changed": channel_message_changed_event_body,
-            "bot_message_channel": bot_message_event_payload,
-            "thread_started": thread_started_event_body,
-            "thread_context_changed": thread_context_changed_event_body,
-            "reaction_added": reaction_added_event_body,
-            "block_actions": block_actions_body,
-        }
-        for key, body in positives.items():
-            assert is_user_message_event_in_assistant_thread(
-                body
-            ), f"{key} should pass {is_user_message_event_in_assistant_thread.__name__}"
-        for key, body in negatives.items():
-            assert not is_user_message_event_in_assistant_thread(
-                body
-            ), f"{key} should NOT pass {is_user_message_event_in_assistant_thread.__name__}"
-
-    def test_is_bot_message_event_in_assistant_thread(self):
-        # Requires: is_any_im_message_event + subtype is None + thread_ts present + bot_id present
-        positives = {
-            "bot_im_thread": bot_im_thread_message_body,
-        }
-        negatives = {
-            "user_message_im": user_message_event_body,
-            # file_share_im has subtype="file_share" -- the key user/bot asymmetry
-            "file_share_im": file_share_im_message_body,
-            "im_no_thread_ts": im_message_no_thread_ts_body,
-            "message_changed_im": message_changed_event_body,
-            "channel_user_message": channel_user_message_event_body,
-            "bot_message_channel": bot_message_event_payload,
-            "classic_bot_message_channel": classic_bot_message_event_payload,
-            "thread_started": thread_started_event_body,
-            "thread_context_changed": thread_context_changed_event_body,
-            "reaction_added": reaction_added_event_body,
-            "block_actions": block_actions_body,
-        }
-        for key, body in positives.items():
-            assert is_bot_message_event_in_assistant_thread(
-                body
-            ), f"{key} should pass {is_bot_message_event_in_assistant_thread.__name__}"
-        for key, body in negatives.items():
-            assert not is_bot_message_event_in_assistant_thread(
-                body
-            ), f"{key} should NOT pass {is_bot_message_event_in_assistant_thread.__name__}"
-
-    def test_is_bot_message_user_message_asymmetry(self):
-        # file_share in IM thread: user predicate accepts it, bot predicate rejects it
-        assert is_user_message_event_in_assistant_thread(file_share_im_message_body)
-        assert not is_bot_message_event_in_assistant_thread(file_share_im_message_body)
-
-        # bot message in IM thread: bot predicate accepts it, user predicate rejects it
-        assert is_bot_message_event_in_assistant_thread(bot_im_thread_message_body)
-        assert not is_user_message_event_in_assistant_thread(bot_im_thread_message_body)
-
-    def test_is_other_message_sub_event_in_assistant_thread(self):
-        positives = {
-            "message_changed_im": message_changed_event_body,
-        }
-        negatives = {
-            "user_message_im": user_message_event_body,
-            "bot_im_thread": bot_im_thread_message_body,
-            "im_no_thread_ts": im_message_no_thread_ts_body,
-            "channel_message_changed": channel_message_changed_event_body,
-            "channel_user_message": channel_user_message_event_body,
-            "message_deleted_channel": message_deleted_channel_body,
-            "thread_started": thread_started_event_body,
-            "reaction_added": reaction_added_event_body,
-            "block_actions": block_actions_body,
-        }
-        for key, body in positives.items():
-            assert is_other_message_sub_event_in_assistant_thread(
-                body
-            ), f"{key} should pass {is_other_message_sub_event_in_assistant_thread.__name__}"
-        for key, body in negatives.items():
-            assert not is_other_message_sub_event_in_assistant_thread(
-                body
-            ), f"{key} should NOT pass {is_other_message_sub_event_in_assistant_thread.__name__}"
-
-    def test_is_assistant_event(self):
-        positives = {
-            "thread_started": thread_started_event_body,
-            "thread_context_changed": thread_context_changed_event_body,
-            "user_message_im": user_message_event_body,
-            "user_message_im_with_assistant_thread": user_message_event_body_with_assistant_thread,
-            "file_share_im": file_share_im_message_body,
-            "bot_im_thread": bot_im_thread_message_body,
-        }
-        negatives = {
-            "message_changed_im": message_changed_event_body,
-            "im_no_thread_ts": im_message_no_thread_ts_body,
-            "channel_user_message": channel_user_message_event_body,
-            "channel_message_changed": channel_message_changed_event_body,
-            "bot_message_channel": bot_message_event_payload,
-            "classic_bot_message_channel": classic_bot_message_event_payload,
-            "message_deleted_channel": message_deleted_channel_body,
-            "reaction_added": reaction_added_event_body,
-            "block_actions": block_actions_body,
-        }
-        for key, body in positives.items():
-            assert is_assistant_event(body), f"{key} should pass {is_assistant_event.__name__}"
-        for key, body in negatives.items():
-            assert not is_assistant_event(body), f"{key} should NOT pass {is_assistant_event.__name__}"
-
-    def test_is_assistant_thread_started_event(self):
-        assert is_assistant_thread_started_event(thread_started_event_body)
-
-        negatives = {
-            "thread_context_changed": thread_context_changed_event_body,
-            "user_message_im": user_message_event_body,
-            "message_changed_im": message_changed_event_body,
-            "bot_im_thread": bot_im_thread_message_body,
-            "channel_user_message": channel_user_message_event_body,
-            "reaction_added": reaction_added_event_body,
-            "block_actions": block_actions_body,
-        }
-        for key, body in negatives.items():
-            assert not is_assistant_thread_started_event(
-                body
-            ), f"{key} should NOT pass {is_assistant_thread_started_event.__name__}"
-
-    def test_is_assistant_thread_context_changed_event(self):
-        assert is_assistant_thread_context_changed_event(thread_context_changed_event_body)
-
-        negatives = {
-            "thread_started": thread_started_event_body,
-            "user_message_im": user_message_event_body,
-            "message_changed_im": message_changed_event_body,
-            "bot_im_thread": bot_im_thread_message_body,
-            "channel_user_message": channel_user_message_event_body,
-            "reaction_added": reaction_added_event_body,
-            "block_actions": block_actions_body,
-        }
-        for key, body in negatives.items():
-            assert not is_assistant_thread_context_changed_event(
-                body
-            ), f"{key} should NOT pass {is_assistant_thread_context_changed_event.__name__}"