Change Prometheus recorder factory from New to NewRecorder

Signed-off-by: Xabier Larrakoetxea <[email protected]>

Author: slok

Readme.md

@@ -39,7 +39,7 @@ import (
 func main() {
     // Create our middleware.
     mdlw := middleware.New(middleware.Config{
-        Recorder: metrics.New(metrics.Config{}),
+        Recorder: metrics.NewRecorder(metrics.Config{}),
     })
 
     // Our handler.

examples/custom/main.go

@@ -30,7 +30,7 @@ func main() {
 	reg := prometheus.NewRegistry()
 
 	// Create our middleware.
-	recorder := metrics.New(metrics.Config{
+	recorder := metrics.NewRecorder(metrics.Config{
 		Registry:        reg,
 		Prefix:          "exampleapp",
 		DurationBuckets: []float64{1, 2.5, 5, 10, 20, 40, 80, 160, 320, 640},

examples/default/main.go

@@ -27,7 +27,7 @@ const (
 func main() {
 	// Create our middleware.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	// Create our server.

examples/gorestful/main.go

@@ -22,7 +22,7 @@ const (
 func main() {
 	// Create our middleware.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	// Create our gorestful instance.

examples/httprouter/main.go

@@ -22,7 +22,7 @@ const (
 func main() {
 	// Create our middleware.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	// Create our handlers.

examples/negroni/main.go

@@ -23,7 +23,7 @@ const (
 func main() {
 	// Create our middleware.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	// Create our router.

metrics/prometheus/prometheus.go

@@ -36,9 +36,9 @@ type recorder struct {
 	cfg Config
 }
 
-// New returns a new metrics recorder that implements the recorder
+// NewRecorder returns a new metrics recorder that implements the recorder
 // using Prometheus as the backend.
-func New(cfg Config) metrics.Recorder {
+func NewRecorder(cfg Config) metrics.Recorder {
 	cfg.defaults()
 
 	r := &recorder{

metrics/prometheus/prometheus_test.go

@@ -133,7 +133,7 @@ func TestPrometheusRecorder(t *testing.T) {
 
 			reg := prometheus.NewRegistry()
 			test.config.Registry = reg
-			mrecorder := libprometheus.New(test.config)
+			mrecorder := libprometheus.NewRecorder(test.config)
 			test.recordMetrics(mrecorder)
 
 			// Get the metrics handler and serve.

middleware/example_test.go

@@ -16,7 +16,7 @@ import (
 func ExampleMiddleware_prometheusBackendMiddleware() {
 	// Create our middleware factory with the default settings.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	// Create our handler.

middleware/gorestful/example_test.go

@@ -17,7 +17,7 @@ import (
 func Example_gorestfulMiddleware() {
 	// Create our middleware factory with the default settings.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	// Create our gorestful instance.

middleware/httprouter/example_test.go

@@ -28,7 +28,7 @@ func Example_httprouterMiddlewareByHandler() {
 
 	// Create our middleware factory with the default settings.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 	// Add the middleware.
 	r.GET("/test/:id", httproutermiddleware.Handler("/test/:id", myHandler, mdlw))
@@ -60,7 +60,7 @@ func Example_httprouterMiddlewareOnRouter() {
 
 	// Create our middleware factory with the default settings.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 
 	r.GET("/test/:id", myHandler)

middleware/negroni/example_test.go

@@ -26,7 +26,7 @@ func Example_negroniMiddleware() {
 
 	// Create our middleware.
 	mdlw := middleware.New(middleware.Config{
-		Recorder: metrics.New(metrics.Config{}),
+		Recorder: metrics.NewRecorder(metrics.Config{}),
 	})
 	// Add the middleware to negroni.
 	n.Use(negronimiddleware.Handler("", mdlw))