Skip to content

Commit 3589180

Browse files
Waiman-Longakpm00
authored andcommitted
padata: Fix possible divide-by-0 panic in padata_mt_helper()
We are hit with a not easily reproducible divide-by-0 panic in padata.c at bootup time. [ 10.017908] Oops: divide error: 0000 1 PREEMPT SMP NOPTI [ 10.017908] CPU: 26 PID: 2627 Comm: kworker/u1666:1 Not tainted 6.10.0-15.el10.x86_64 #1 [ 10.017908] Hardware name: Lenovo ThinkSystem SR950 [7X12CTO1WW]/[7X12CTO1WW], BIOS [PSE140J-2.30] 07/20/2021 [ 10.017908] Workqueue: events_unbound padata_mt_helper [ 10.017908] RIP: 0010:padata_mt_helper+0x39/0xb0 : [ 10.017963] Call Trace: [ 10.017968] <TASK> [ 10.018004] ? padata_mt_helper+0x39/0xb0 [ 10.018084] process_one_work+0x174/0x330 [ 10.018093] worker_thread+0x266/0x3a0 [ 10.018111] kthread+0xcf/0x100 [ 10.018124] ret_from_fork+0x31/0x50 [ 10.018138] ret_from_fork_asm+0x1a/0x30 [ 10.018147] </TASK> Looking at the padata_mt_helper() function, the only way a divide-by-0 panic can happen is when ps->chunk_size is 0. The way that chunk_size is initialized in padata_do_multithreaded(), chunk_size can be 0 when the min_chunk in the passed-in padata_mt_job structure is 0. Fix this divide-by-0 panic by making sure that chunk_size will be at least 1 no matter what the input parameters are. Link: https://lkml.kernel.org/r/[email protected] Fixes: 004ed42 ("padata: add basic support for multithreaded jobs") Signed-off-by: Waiman Long <[email protected]> Cc: Daniel Jordan <[email protected]> Cc: Steffen Klassert <[email protected]> Cc: Waiman Long <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent dcdfab5 commit 3589180

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

kernel/padata.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,13 @@ void __init padata_do_multithreaded(struct padata_mt_job *job)
517517
ps.chunk_size = max(ps.chunk_size, job->min_chunk);
518518
ps.chunk_size = roundup(ps.chunk_size, job->align);
519519

520+
/*
521+
* chunk_size can be 0 if the caller sets min_chunk to 0. So force it
522+
* to at least 1 to prevent divide-by-0 panic in padata_mt_helper().`
523+
*/
524+
if (!ps.chunk_size)
525+
ps.chunk_size = 1U;
526+
520527
list_for_each_entry(pw, &works, pw_list)
521528
if (job->numa_aware) {
522529
int old_node = atomic_read(&last_used_nid);

0 commit comments

Comments
 (0)