Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade JPMS support to an automatic module declaration #1406

Closed
jponge opened this issue Oct 17, 2023 · 1 comment
Closed

Downgrade JPMS support to an automatic module declaration #1406

jponge opened this issue Oct 17, 2023 · 1 comment

Comments

@jponge
Copy link
Member

jponge commented Oct 17, 2023 •
edited
Loading

I'm considering downgrading our support of JPMS (aka Java Modules) to that of automatic modules via a manifest declaration.

AFAIK Quarkus, Vert.x, Reactive Messaging and Hibernate Reactive are our most prominent downstream consumers, and none is using Java modules.

Also the ongoing efforts on #1330 show that consuming a library with neither a module descriptor nor an automatic module is complicated.

Thoughts?
jponge added a commit that referenced this issue Oct 25, 2023
@jponge
feat!: downgrade Java modules support to automatic modules
c99bf1d 
Issue: #1406

BREAKING CHANGE: the Mutiny library is now exposed as an
automatic module rather than a module with a module-info
descriptor.
@jponge jponge mentioned this issue Oct 25, 2023
Closed
@jponge jponge linked a pull request Oct 25, 2023 that will close this issue
feat!: downgrade Java modules support to automatic modules #1415
Closed
@jponge
Copy link
Member Author

jponge commented Oct 26, 2023

We won't go this way, we'll either have a JCTools release soon or we will use a fork.

The current JCTools master branch has a correct (generated) module-info that I've been able to test locally.

@jponge jponge closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: downgrade Java modules support to automatic modules smallrye/smallrye-mutiny
1 participant
@jponge