Skip to content

Commit 58f3a66

Browse files
committed
docs: finish Teams→ServerEdition rename leftovers (MCP-1795)
Codex review follow-up for PR #603 / MCP-1086: - generate-release-notes.sh: server-edition code path internal/teams/ → internal/serveredition/ - specs/029-mcpproxy-teams/tasks.md: build-tag docs //go:build teams / -tags teams → server, matching the accepted scope (build tag remains "server", current code uses //go:build server). Package paths were already renamed by PR #603; only the build-tag references were stale. Edition-name/wording strings left untouched (owned by MCP-1087). Related #603
1 parent b694908 commit 58f3a66

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

scripts/generate-release-notes.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ build_prompt() {
128128
cat << EOF
129129
Generate concise release notes for version ${version} of MCPProxy (Smart MCP Proxy).
130130
131-
MCPProxy is built in two editions from the same codebase: a default Personal edition (desktop app, distributed as DMG / Windows installer / Linux tar.gz / .deb / .rpm) and a Server edition built with the \`server\` Go build tag (Docker image + multi-user OAuth, code under \`internal/teams/\`). Most changes ship in BOTH editions because shared code (\`internal/runtime/\`, \`internal/server/\`, \`internal/upstream/\`, \`frontend/\`, etc.) is compiled into both binaries.
131+
MCPProxy is built in two editions from the same codebase: a default Personal edition (desktop app, distributed as DMG / Windows installer / Linux tar.gz / .deb / .rpm) and a Server edition built with the \`server\` Go build tag (Docker image + multi-user OAuth, code under \`internal/serveredition/\`). Most changes ship in BOTH editions because shared code (\`internal/runtime/\`, \`internal/server/\`, \`internal/upstream/\`, \`frontend/\`, etc.) is compiled into both binaries.
132132
133133
Commits since last release:
134134
${commits}

specs/029-mcpproxy-teams/tasks.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,34 +16,34 @@
1616
**Purpose**: Establish the build tag architecture that separates personal and teams editions
1717

1818
- [x] T001 [P] Create edition detection file `cmd/mcpproxy/edition.go` with `var Edition = "personal"` and `GetEdition()` function
19-
- [x] T002 [P] Create teams edition override file `cmd/mcpproxy/edition_teams.go` with `//go:build teams` tag that sets `Edition = "teams"`
19+
- [x] T002 [P] Create teams edition override file `cmd/mcpproxy/edition_teams.go` with `//go:build server` tag that sets `Edition = "teams"`
2020
- [x] T003 Update `cmd/mcpproxy/main.go` to log edition on startup and pass edition to server initialization
2121
- [x] T004 Add edition field to `/api/v1/status` response in `internal/httpapi/server.go`
2222
- [x] T005 Add edition to `mcpproxy version` CLI output in `cmd/mcpproxy/main.go`
2323

24-
**Checkpoint**: `go build ./cmd/mcpproxy && ./mcpproxy version` shows "personal"; `go build -tags teams ./cmd/mcpproxy && ./mcpproxy version` shows "teams"
24+
**Checkpoint**: `go build ./cmd/mcpproxy && ./mcpproxy version` shows "personal"; `go build -tags server ./cmd/mcpproxy && ./mcpproxy version` shows "teams"
2525

2626
---
2727

2828
## Phase 2: Teams Skeleton (internal/serveredition/)
2929

3030
**Purpose**: Create the teams feature registry and package skeleton with build tags
3131

32-
- [x] T006 Create `internal/serveredition/doc.go` with `//go:build teams` tag and package documentation
32+
- [x] T006 Create `internal/serveredition/doc.go` with `//go:build server` tag and package documentation
3333
- [x] T007 Create `internal/serveredition/registry.go` with Feature struct, Register(), SetupAll() functions (build-tagged)
3434
- [x] T008 Create `internal/serveredition/registry_test.go` with tests verifying registration and setup (build-tagged)
35-
- [x] T009 Create teams registration entry point `cmd/mcpproxy/teams_register.go` with `//go:build teams` that imports `internal/serveredition` and calls `SetupAll()` during init
36-
- [x] T010 Verify both builds compile: `go build ./cmd/mcpproxy` (no teams code) and `go build -tags teams ./cmd/mcpproxy` (with teams skeleton)
35+
- [x] T009 Create teams registration entry point `cmd/mcpproxy/teams_register.go` with `//go:build server` that imports `internal/serveredition` and calls `SetupAll()` during init
36+
- [x] T010 Verify both builds compile: `go build ./cmd/mcpproxy` (no teams code) and `go build -tags server ./cmd/mcpproxy` (with teams skeleton)
3737

38-
**Checkpoint**: `go test -tags teams ./internal/serveredition/...` passes; personal build has zero teams code compiled in
38+
**Checkpoint**: `go test -tags server ./internal/serveredition/...` passes; personal build has zero teams code compiled in
3939

4040
---
4141

4242
## Phase 3: Dockerfile & Build Targets
4343

4444
**Purpose**: Create Docker distribution for teams edition and extend Makefile
4545

46-
- [x] T011 [P] Create `Dockerfile` at repo root — multi-stage build with `golang:1.24` builder, `gcr.io/distroless/base` runtime, builds with `-tags teams`, embeds frontend, exposes 8080, entrypoint `mcpproxy serve --listen 0.0.0.0:8080`
46+
- [x] T011 [P] Create `Dockerfile` at repo root — multi-stage build with `golang:1.24` builder, `gcr.io/distroless/base` runtime, builds with `-tags server`, embeds frontend, exposes 8080, entrypoint `mcpproxy serve --listen 0.0.0.0:8080`
4747
- [x] T012 [P] Create `.dockerignore` excluding `.git`, `node_modules`, `native/`, `*.md`, test files
4848
- [x] T013 Add Makefile targets: `build-teams` (Go binary with teams tag), `build-docker` (Docker image), `build-deb` (placeholder echoing "TODO")
4949
- [x] T014 Verify `make build` still produces personal edition (no regression)
@@ -79,7 +79,7 @@
7979

8080
**Purpose**: Extend GitHub Actions release workflow to build teams assets alongside personal
8181

82-
- [x] T020 Add teams Linux matrix entries (amd64, arm64) to `.github/workflows/release.yml` build job — uses `-tags teams` flag, produces `mcpproxy-teams-*` archives
82+
- [x] T020 Add teams Linux matrix entries (amd64, arm64) to `.github/workflows/release.yml` build job — uses `-tags server` flag, produces `mcpproxy-teams-*` archives
8383
- [x] T021 Add `build-docker` job to `.github/workflows/release.yml` — builds and pushes `ghcr.io/smart-mcp-proxy/mcpproxy-teams:$VERSION` on tag push
8484
- [x] T022 Update release notes prompt in `.github/workflows/release.yml` to mention both editions
8585
- [x] T023 Update release asset upload to include teams archives with `mcpproxy-teams-` prefix
@@ -95,7 +95,7 @@
9595
- [x] T024 Update `CLAUDE.md` — add Build & Distribution section documenting `build-teams`, `build-docker`, edition detection, `internal/serveredition/` structure
9696
- [x] T025 Update `Makefile` help target to include new build-teams, build-docker, build-deb targets
9797
- [x] T026 Verify all existing tests pass: `go test ./internal/... -v` (personal build) — all pass except pre-existing `internal/server` timeout
98-
- [x] T027 Verify teams build tests pass: `go test -tags teams ./internal/serveredition/... -v`
98+
- [x] T027 Verify teams build tests pass: `go test -tags server ./internal/serveredition/... -v`
9999
- [x] T028 Verify E2E tests pass: `./scripts/test-api-e2e.sh` — 61/71 pass, 10 failures are pre-existing (same on clean branch)
100100
- [x] T029 Verify linter passes: `./scripts/run-linter.sh`
101101

0 commit comments

Comments
 (0)