Shouldn't having a command fail raise an error?

[cultab]

I spent way too long adding vim.notify to track why split navigation suddenly stopped working only to realise wezterm.exe just wasn't on my path anymore (/etc/wsl.conf's appendWindowsPath = false for zsh performance reasons). I feel like failing commands (or missing since it also would also return a non zero code) should maybe raise an error, be that on the log file that already exists or through vim.notify.

I could try and get a PR ready, if this behavior is wanted.

[mrjones2014]

I tried to do that here https://github.com/mrjones2014/smart-splits.nvim/blob/c697ea84309db323e4da82d29c1f23304e6910be/lua/smart-splits/utils.lua#L32-L35

But there must be a bug.

[cultab]

latest tagged release that is, will check with HEAD too

[mrjones2014]

Yeah I cannot reproduce on HEAD.

It's a bit overdue to tag a new bugfix release anyway so I'll tag a new one.

[cultab]

seems something is "eating" the error, error(... is not executable ..) is definitely called)
(stopped replying here and forgot to send and started looking into it)
yep, at https://github.com/mrjones2014/smart-splits.nvim/blob/c697ea84309db323e4da82d29c1f23304e6910be/lua/smart-splits/api.lua#L512
we have a pcall who's return isn't checked, so it's eating the error.

If I remove it the error bubbles up:

E5108: Lua: Vim:Lua :command callback: ...repos/smart-splits.nvim/lua/smart-splits/mux/wezterm.lua:39: Expected value but found invalid token at character 1
stack traceback:
        [C]: in function 'decode'
        ...repos/smart-splits.nvim/lua/smart-splits/mux/wezterm.lua:39: in function 'init_tab_id'
        ...repos/smart-splits.nvim/lua/smart-splits/mux/wezterm.lua:53: in function 'current_pane_info'
        ...repos/smart-splits.nvim/lua/smart-splits/mux/wezterm.lua:81: in function 'current_pane_id'
        ...repos/smart-splits.nvim/lua/smart-splits/mux/wezterm.lua:116: in function 'is_in_session'
        ...an/repos/smart-splits.nvim/lua/smart-splits/mux/init.lua:86: in function 'move_pane'
        /home/evan/repos/smart-splits.nvim/lua/smart-splits/api.lua:380: in function 'move_cursor'
        /home/evan/repos/smart-splits.nvim/lua/smart-splits/api.lua:512: in function </home/evan/repos/smart-splits.nvim/lua/smart-splits/api.lua:510>
        ...an/repos/smart-splits.nvim/lua/smart-splits/commands.lua:20: in function <...an/repos/smart-splits.nvim/lua/smart-splits/commands.lua:15>
        [C]: at 0x5899b0c4da10
stack traceback:
        [C]: at 0x5899b0c4da10

it's quite incomprehensible for users but you can clearly see it's failing at init_tab_id that does a wezterm_exec and thus a require(smartsplit).system('wezterm.exe' ...) that fails.

Maybe check pcall's return and vim.notify an error?

Still don't know why you can't reproduce, maybe other backends have different error handling (or I didn't explain the issue thoroughly enough :P)?

[cultab]

gonna open an issue to track my thoughs

[cultab]

#385