Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for imperial units... again #1042

Open
devbyaccident opened this issue Apr 25, 2023 · 9 comments · May be fixed by #1103 or #1326
Open

Adding support for imperial units... again #1042

devbyaccident opened this issue Apr 25, 2023 · 9 comments · May be fixed by #1103 or #1326

Comments

@devbyaccident
Copy link

It looks like there have been several issues raised for this already, (#29, #155, #160, #669, and #686) and a couple of pull requests that got closed without being merged (#692, #795) but SmartIR still doesn't have support for imperial units/Fahrenheit.

Can one of the maintainers please add this feature? Or at least turn off stalebot while it's being worked on?

@KidA001
Copy link

KidA001 commented Jun 9, 2023

Is anyone maintaining this project any more or is it dead?

@devbyaccident
Copy link
Author

devbyaccident commented Jun 12, 2023

I have no idea... FWIW, I copied the contents from climate.py in #795 to my HA config, (Props to @kevin-brown, that was some solid work) and it works fine for me. Haven't put it in a branch or anything, but a forked copy would work fine.

Edit: Typo

image

@tcj-one
Copy link

tcj-one commented Jun 27, 2023

We just had 48d7f1f 2 weeks ago, @vassilis-panos clearly has the power to merge things. So I'm not sure why #795 has been ignored.

Would love to get this implemented.

@TheAppleFreak
Copy link

TheAppleFreak commented Jul 5, 2023

Yep, I got bit by this too. It actually makes it impossible to control devices using Apple Home, as the gauge to control the temperature starts well above the max temperature in my device's codes with this incorrect conversion.

Screenshot of the Apple Home app

IMG_4863

@devbyaccident devbyaccident linked a pull request Aug 2, 2023 that will close this issue
@devbyaccident
Copy link
Author

Ok, I just put in a PR for it, hope you don't mind co-author @kevin-brown, but this is long overdue.

LMK if causes issues and I'll close

@tcj-one
Copy link

tcj-one commented Dec 15, 2023

We've had 3 releases since #795 and 2 since #1103, with absolutely no progress or comment on why these are being ignored.

@vassilis-panos, can we get some response as to what's going on here?

@nelsonjchen
Copy link

nelsonjchen commented Dec 16, 2023 via email

@tcj-one
Copy link

tcj-one commented Dec 17, 2023

It's just such a silly thing to fork over. There's no need to duplicate effort in other places to support the rest of the project in Fahrenheit. The entire change is 15 lines of code, it can and should easily coexist here.

@jhstatewide
Copy link

It's just such a silly thing to fork over. There's no need to duplicate effort in other places to support the rest of the project in Fahrenheit. The entire change is 15 lines of code, it can and should easily coexist here.

Sure, if you don't mind not being able to update SmartIR without manually altering climate.py each time (and also hoping the above diff doesn't get outdated...)

It'd be nice if the maintainer of this project could weigh in re: why this isn't getting merged. If it's a bad idea, it could be reworked or definitively say that imperial support is out of scope for this project.

Since there appears to be no feedback, all we can do is guess why these patches just sit there.

@ardichoke ardichoke linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants