-
Notifications
You must be signed in to change notification settings - Fork 8
EVM: implement getFallbackArchiveLogs #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrevmatos
wants to merge
8
commits into
main
Choose a base branch
from
evm/fallback_archive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 andrevmatos, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Coverage Report |
fallback to public list of archive RPCs, race them for some wide-range getLogs when requested (e.g. for v1.5 `FeeConfigSet` events)
1977eb7 to
9756c19
Compare
Should safely allow larger global rateLimits
- ChainTransaction and ChainFamily to types - CLI provider returns Chain and Tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVM.getLogsgenerator into an utility functiononlyFallback, which may be:undefined: current behavior, paginate on main provider RPCfalse: first try wide range on main provider, then (if can't), falls back to public archive RPCs and race them, then fallsback to paginationtrue: do only wide range on main, then fallback provider; throws if it can'tonlyFallback=trueto fetch v1.5FeeConfigSetevents to collectfeeTokens