PR feedback

Author: nolag

pkg/workflows/internal/v2/sdkimpl/runtime_test.go

@@ -67,6 +67,7 @@ func TestRuntime_CallCapability(t *testing.T) {
 	})
 
 	t.Run("call capability errors", func(t *testing.T) {
+		// The capability is not registered, so the call will fail.
 		test := func(rt sdk.DonRuntime, _ *basictrigger.Outputs) (string, error) {
 			workflowAction1 := &basicaction.BasicAction{}
 			call := workflowAction1.PerformAction(rt, &basicaction.Inputs{InputThing: true})
@@ -77,7 +78,7 @@ func TestRuntime_CallCapability(t *testing.T) {
 		assert.Error(t, err)
 	})
 
-	t.Run("capability errors", func(t *testing.T) {
+	t.Run("capability errors are returned to the caller", func(t *testing.T) {
 		action, err := basicactionmock.NewBasicActionCapability(t)
 		require.NoError(t, err)
 

pkg/workflows/sdk/v2/const.go

@@ -3,5 +3,5 @@ package sdk
 const (
 	IdLen                       = 36              // IdLen is 36 bytes to match a UUID's string length
 	DefaultMaxResponseSizeBytes = 5 * 1024 * 1024 // 5 MB
-	ResponseBufferToSmall       = "response buffer too small"
+	ResponseBufferTooSmall      = "response buffer too small"
 )

pkg/workflows/sdk/v2/testutils/runtime.go

@@ -83,7 +83,7 @@ func createAwaitCapabilities(tb testing.TB) sdkimpl.AwaitCapabilitiesFn {
 
 		bytes, _ := proto.Marshal(response)
 		if len(bytes) > int(maxResponseSize) {
-			return nil, errors.New(sdk.ResponseBufferToSmall)
+			return nil, errors.New(sdk.ResponseBufferTooSmall)
 		}
 
 		return response, errors.Join(errs...)

pkg/workflows/sdk/v2/testutils/runtime_test.go

@@ -52,7 +52,7 @@ func TestRuntime_CallCapability(t *testing.T) {
 
 		_, _, err = runner.Result()
 		require.Error(t, err)
-		assert.True(t, strings.Contains(err.Error(), sdk.ResponseBufferToSmall))
+		assert.True(t, strings.Contains(err.Error(), sdk.ResponseBufferTooSmall))
 	})
 }
 

pkg/workflows/wasm/host/module.go

@@ -1110,7 +1110,7 @@ func createAwaitCapsFn(
 
 		size := wasmWrite(caller, respBytes, responseBuffer, maxResponseLen)
 		if size == -1 {
-			errStr := sdk.ResponseBufferToSmall
+			errStr := sdk.ResponseBufferTooSmall
 			logger.Error(errStr)
 			return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen)
 		}

pkg/workflows/wasm/host/wasip1.go

@@ -22,7 +22,6 @@ func newWasiLinker(modCfg *ModuleConfig, engine *wasmtime.Engine) (*wasmtime.Lin
 	linker.AllowShadowing(true)
 
 	err := linker.DefineWasi()
-
 	if err != nil {
 		return nil, err
 	}

pkg/workflows/wasm/host/wasm_nodag_test.go

@@ -49,7 +49,7 @@ func Test_NoDag_Run(t *testing.T) {
 	require.NoError(t, err)
 	m.Start()
 
-	// When a TriggerEvent occurs, Engine calls Run() with that Event.
+	// When a TriggerEvent occurs, Engine calls Execute with that Event.
 	trigger := &basictrigger.Outputs{CoolOutput: "Hi"}
 	wrapped, err := anypb.New(trigger)
 	require.NoError(t, err)

pkg/workflows/wasm/pb/wasm.pb.go

@@ -24,7 +24,6 @@ message Request {
     ComputeRequest computeRequest = 3;
     google.protobuf.Empty specRequest = 4;
   }
-  string triggerId = 5;
 }
 
 message ComputeResponse { capabilities.CapabilityResponse response = 1; }

pkg/workflows/wasm/pb/wasm.proto

@@ -52,7 +52,7 @@ func (d *runner[T]) Run(args *sdk.WorkflowArgs[T]) {
 	versionV2()
 	for _, handler := range args.Handlers {
 		// TODO: https://smartcontract-it.atlassian.net/browse/CAPPL-809 multiple of the same trigger registered
-		// The ID field could be changed to tirger-# and we can use the index or similar.
+		// The ID field could be changed to trigger-# and we can use the index or similar.
 		if handler.Id() == d.trigger.Id {
 			response, err := handler.Callback()(d.runtime, d.trigger.Payload)
 			execResponse := &pb.ExecutionResult{Id: d.id}