DF-21713 Remove unused rest transport for cfbenchmarks (#4102)

Author: cll-gg

.changeset/lemon-badgers-flash.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/cfbenchmarks-adapter': minor
+---
+
+Remove rest endpoint from cfbenchmarks since it's unused.

packages/sources/cfbenchmarks/src/endpoint/crypto.ts

@@ -3,10 +3,8 @@ import { TransportRoutes } from '@chainlink/external-adapter-framework/transport
 import { SingleNumberResultResponse } from '@chainlink/external-adapter-framework/util'
 import { InputParameters } from '@chainlink/external-adapter-framework/validation/input-params'
 import { config } from '../config'
-import { customInputValidation } from './utils'
-import { makeRestTransport } from '../transport/crypto-http'
 import { makeWsTransport } from '../transport/crypto-ws'
-import { requestTransform } from './utils'
+import { customInputValidation, requestTransform } from './utils'
 
 export type Params = { index?: string; base?: string; quote?: string }
 export type RequestParams = { Params: Params }
@@ -58,14 +56,11 @@ export const endpoint = new CryptoPriceEndpoint({
   inputParameters,
   requestTransforms,
   transportRoutes: new TransportRoutes<BaseEndpointTypes>()
-    .register('rest', makeRestTransport('primary'))
-    .register('restsecondary', makeRestTransport('secondary'))
     .register('ws', makeWsTransport('primary'))
     .register('wssecondary', makeWsTransport('secondary')),
   defaultTransport: 'ws',
   customRouter: (req, adapterConfig) => {
     if (adapterConfig.API_SECONDARY) {
-      if (req.requestContext.transportName === 'rest') return 'restsecondary'
       return 'wssecondary'
     } else {
       return req.requestContext.transportName

packages/sources/cfbenchmarks/src/transport/crypto-http.ts

@@ -1,17 +1,4 @@
 import { MockWebsocketServer } from '@chainlink/external-adapter-framework/util/testing-utils'
-import nock from 'nock'
-
-export const mockResponseSuccess = (): nock.Scope =>
-  nock('https://www.cfbenchmarks.com/api')
-    .get('/v1/values?id=BRTI')
-    .reply(200, {
-      serverTime: '2022-02-18T16:53:55.772Z',
-      payload: [
-        { value: '39829.42', time: 1645199636000 },
-        { value: '39829.30', time: 1645199637000 },
-      ],
-    })
-    .persist()
 
 export const mockWebSocketServer = (URL: string): MockWebsocketServer => {
   const mockWsServer = new MockWebsocketServer(URL, { mock: false })