Skip to content

Commit 80a93c1

Browse files
authored
chore: fix clippy (#276)
Co-authored-by: Luis Moreno <[email protected]>
1 parent 4eadd16 commit 80a93c1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/linalg/basic/matrix.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -193,11 +193,11 @@ impl<T: Debug + Display + Copy + Sized> DenseMatrix<T> {
193193

194194
/// New instance of `DenseMatrix` from 2d array.
195195
pub fn from_2d_array(values: &[&[T]]) -> Self {
196-
DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect())
196+
DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect::<Vec<_>>())
197197
}
198198

199199
/// New instance of `DenseMatrix` from 2d vector.
200-
pub fn from_2d_vec(values: &Vec<Vec<T>>) -> Self {
200+
pub fn from_2d_vec(values: &[Vec<T>]) -> Self {
201201
let nrows = values.len();
202202
let ncols = values
203203
.first()

src/preprocessing/numerical.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,11 @@ mod tests {
197197
fn combine_three_columns() {
198198
assert_eq!(
199199
build_matrix_from_columns(vec![
200-
DenseMatrix::from_2d_vec(&vec![vec![1.0], vec![1.0], vec![1.0],]),
201-
DenseMatrix::from_2d_vec(&vec![vec![2.0], vec![2.0], vec![2.0],]),
202-
DenseMatrix::from_2d_vec(&vec![vec![3.0], vec![3.0], vec![3.0],])
200+
DenseMatrix::from_2d_vec(&[vec![1.0], vec![1.0], vec![1.0]]),
201+
DenseMatrix::from_2d_vec(&[vec![2.0], vec![2.0], vec![2.0]]),
202+
DenseMatrix::from_2d_vec(&[vec![3.0], vec![3.0], vec![3.0]])
203203
]),
204-
Some(DenseMatrix::from_2d_vec(&vec![
204+
Some(DenseMatrix::from_2d_vec(&[
205205
vec![1.0, 2.0, 3.0],
206206
vec![1.0, 2.0, 3.0],
207207
vec![1.0, 2.0, 3.0]
@@ -365,7 +365,7 @@ mod tests {
365365
);
366366

367367
assert!(
368-
&DenseMatrix::<f64>::from_2d_vec(&vec![fitted_scaler.stds]).approximate_eq(
368+
&DenseMatrix::<f64>::from_2d_vec(&[fitted_scaler.stds]).approximate_eq(
369369
&DenseMatrix::from_2d_array(&[&[
370370
0.29426447500954,
371371
0.16758497615485,

0 commit comments

Comments
 (0)