chore: upgrade @typescript-eslint packages (#1580)

Author: kuhe

.changeset/sour-singers-chew.md

@@ -0,0 +1,2 @@
+---
+---

.eslintrc.js

@@ -21,6 +21,14 @@ module.exports = {
     "prefer-rest-params": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
 
+    // intentional usage
+    "@typescript-eslint/no-empty-object-type": "off",
+    "@typescript-eslint/no-unsafe-function-type": "off",
+
+    // temporary until upgrading ESLint
+    "@typescript-eslint/no-unused-vars": "off",
+    "@typescript-eslint/no-require-imports": "off",
+
     /** Warnings */
     "@typescript-eslint/no-namespace": "warn",
 

package.json

@@ -39,8 +39,8 @@
     "@tsconfig/recommended": "1.0.2",
     "@types/jest": "28.1.3",
     "@types/jsdom": "20.0.1",
-    "@typescript-eslint/eslint-plugin": "7.8.0",
-    "@typescript-eslint/parser": "7.8.0",
+    "@typescript-eslint/eslint-plugin": "8.32.0",
+    "@typescript-eslint/parser": "8.32.0",
     "esbuild": "0.19.11",
     "eslint": "8.57.0",
     "eslint-plugin-simple-import-sort": "7.0.0",

packages/eventstream-codec/src/MessageEncoderStream.ts

@@ -6,7 +6,7 @@ import { Message, MessageEncoder } from "@smithy/types";
 export interface MessageEncoderStreamOptions {
   messageStream: AsyncIterable<Message>;
   encoder: MessageEncoder;
-  includeEndFrame?: Boolean;
+  includeEndFrame?: boolean;
 }
 
 /**

packages/eventstream-codec/src/SmithyMessageDecoderStream.spec.ts

@@ -24,12 +24,12 @@ describe("SmithyMessageDecoderStream", () => {
       yield message2;
     };
 
-    const stream = new SmithyMessageDecoderStream<String>({
+    const stream = new SmithyMessageDecoderStream<string>({
       messageStream: inputStream(),
       deserializer: deserializer,
     });
 
-    const messages: Array<String> = [];
+    const messages: Array<string> = [];
     for await (const str of stream) {
       messages.push(str);
     }

packages/eventstream-codec/src/SmithyMessageEncoderStream.spec.ts

@@ -22,7 +22,7 @@ describe("SmithyMessageEncoderStream", () => {
       yield "second";
     };
 
-    const stream = new SmithyMessageEncoderStream<String>({
+    const stream = new SmithyMessageEncoderStream<string>({
       inputStream: inputStream(),
       serializer: serializer,
     });

packages/smithy-client/src/date-utils.ts

@@ -2,11 +2,11 @@
 import { strictParseByte, strictParseDouble, strictParseFloat32, strictParseShort } from "./parse-utils";
 
 // Build indexes outside so we allocate them once.
-const DAYS: Array<String> = ["Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"];
+const DAYS: Array<string> = ["Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"];
 
 // These must be kept in order
 // prettier-ignore
-const MONTHS: Array<String> = ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"];
+const MONTHS: Array<string> = ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"];
 
 /**
  * @internal

packages/smithy-client/src/lazy-json.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-wrapper-object-types */
 /**
  * @public
  *
@@ -14,7 +15,6 @@ export type AutomaticJsonStringConversion = Parameters<typeof JSON.stringify>[0]
 
 /**
  * @internal
- *
  */
 export interface LazyJsonString extends String {
   /**

private/util-test/src/test-http-handler.ts

@@ -36,15 +36,15 @@ const MOCK_CREDENTIALS = {
   secretAccessKey: "MOCK_SECRET_ACCESS_KEY_ID",
 };
 
-interface TestHttpHandlerConfig {}
+type TestHttpHandlerConfig = object;
 
 /**
  * Supplied to test clients to assert correct requests.
  * @internal
  */
 export class TestHttpHandler implements HttpHandler<TestHttpHandlerConfig> {
   private static WATCHER = Symbol("TestHttpHandler_WATCHER");
-  private originalSend?: Function;
+  private originalSend?: Client<any, any, any>["send"];
   private originalRequestHandler?: RequestHandler<any, any, any>;
   private client?: Client<any, any, any>;
   private assertions = 0;

smithy-typescript-ssdk-libs/server-node/src/index.spec.ts

@@ -29,7 +29,7 @@ beforeAll(async () => {
 
 let resToEnd: ServerResponse;
 
-function getRequest(options: RequestOptions & { body?: String }): Promise<[IncomingMessage, ServerResponse]> {
+function getRequest(options: RequestOptions & { body?: string }): Promise<[IncomingMessage, ServerResponse]> {
   return new Promise((resolve) => {
     promiseResolve = resolve;
     request({