fix(cbor): copy headers when building request

Author: kuhe

.changeset/friendly-parents-compare.md

@@ -0,0 +1,5 @@
+---
+"@smithy/core": patch
+---
+
+copy input headers when building RPCv2 CBOR request

packages/core/src/submodules/cbor/parseCborBody.spec.ts

@@ -0,0 +1,32 @@
+import { buildHttpRpcRequest } from "./parseCborBody";
+
+import { describe, test as it, expect } from "vitest";
+
+describe("buildHttpRpcRequest", () => {
+  it("should copy the input headers", async () => {
+    const headers = {
+      "content-type": "application/cbor",
+      "smithy-protocol": "rpc-v2-cbor",
+      accept: "application/cbor",
+      "content-length": "0",
+    };
+
+    const request = await buildHttpRpcRequest(
+      {
+        async endpoint() {
+          return {
+            hostname: "https://localhost",
+            path: "/",
+          };
+        },
+      } as any,
+      headers,
+      "/",
+      "",
+      ""
+    );
+
+    expect(request.headers).toEqual(headers);
+    expect(request.headers).not.toBe(headers);
+  });
+});

packages/core/src/submodules/cbor/parseCborBody.ts

@@ -100,7 +100,10 @@ export const buildHttpRpcRequest = async (
     port,
     method: "POST",
     path: basePath.endsWith("/") ? basePath.slice(0, -1) + path : basePath + path,
-    headers,
+    headers: {
+      // intentional copy.
+      ...headers,
+    },
   };
   if (resolvedHostname !== undefined) {
     contents.hostname = resolvedHostname;

private/smithy-rpcv2-cbor/src/auth/httpAuthSchemeProvider.ts

@@ -7,8 +7,9 @@ import {
   HttpAuthSchemeParameters,
   HttpAuthSchemeParametersProvider,
   HttpAuthSchemeProvider,
+  Provider,
 } from "@smithy/types";
-import { getSmithyContext } from "@smithy/util-middleware";
+import { getSmithyContext, normalizeProvider } from "@smithy/util-middleware";
 
 /**
  * @internal
@@ -68,6 +69,14 @@ export const defaultRpcV2ProtocolHttpAuthSchemeProvider: RpcV2ProtocolHttpAuthSc
  * @internal
  */
 export interface HttpAuthSchemeInputConfig {
+  /**
+   * A comma-separated list of case-sensitive auth scheme names.
+   * An auth scheme name is a fully qualified auth scheme ID with the namespace prefix trimmed.
+   * For example, the auth scheme with ID aws.auth#sigv4 is named sigv4.
+   * @public
+   */
+  authSchemePreference?: string[] | Provider<string[]>;
+
   /**
    * Configuration of HttpAuthSchemes for a client which provides default identity providers and signers per auth scheme.
    * @internal
@@ -85,6 +94,14 @@ export interface HttpAuthSchemeInputConfig {
  * @internal
  */
 export interface HttpAuthSchemeResolvedConfig {
+  /**
+   * A comma-separated list of case-sensitive auth scheme names.
+   * An auth scheme name is a fully qualified auth scheme ID with the namespace prefix trimmed.
+   * For example, the auth scheme with ID aws.auth#sigv4 is named sigv4.
+   * @public
+   */
+  readonly authSchemePreference: Provider<string[]>;
+
   /**
    * Configuration of HttpAuthSchemes for a client which provides default identity providers and signers per auth scheme.
    * @internal
@@ -104,5 +121,7 @@ export interface HttpAuthSchemeResolvedConfig {
 export const resolveHttpAuthSchemeConfig = <T>(
   config: T & HttpAuthSchemeInputConfig
 ): T & HttpAuthSchemeResolvedConfig => {
-  return Object.assign(config, {}) as T & HttpAuthSchemeResolvedConfig;
+  return Object.assign(config, {
+    authSchemePreference: normalizeProvider(config.authSchemePreference ?? []),
+  }) as T & HttpAuthSchemeResolvedConfig;
 };

private/smithy-rpcv2-cbor/src/commands/EmptyInputOutputCommand.ts

@@ -49,6 +49,7 @@ export interface EmptyInputOutputCommandOutput extends EmptyStructure, __Metadat
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class EmptyInputOutputCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/Float16Command.ts

@@ -51,6 +51,7 @@ export interface Float16CommandOutput extends Float16Output, __MetadataBearer {}
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class Float16Command extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/FractionalSecondsCommand.ts

@@ -51,6 +51,7 @@ export interface FractionalSecondsCommandOutput extends FractionalSecondsOutput,
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class FractionalSecondsCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/GreetingWithErrorsCommand.ts

@@ -63,6 +63,7 @@ export interface GreetingWithErrorsCommandOutput extends GreetingWithErrorsOutpu
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  * @public
  */
 export class GreetingWithErrorsCommand extends $Command

private/smithy-rpcv2-cbor/src/commands/NoInputOutputCommand.ts

@@ -48,6 +48,7 @@ export interface NoInputOutputCommandOutput extends __MetadataBearer {}
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class NoInputOutputCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/OperationWithDefaultsCommand.ts

@@ -117,6 +117,7 @@ export interface OperationWithDefaultsCommandOutput extends OperationWithDefault
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class OperationWithDefaultsCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/OptionalInputOutputCommand.ts

@@ -53,6 +53,7 @@ export interface OptionalInputOutputCommandOutput extends SimpleStructure, __Met
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class OptionalInputOutputCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/RecursiveShapesCommand.ts

@@ -77,6 +77,7 @@ export interface RecursiveShapesCommandOutput extends RecursiveShapesInputOutput
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class RecursiveShapesCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/RpcV2CborDenseMapsCommand.ts

@@ -93,6 +93,7 @@ export interface RpcV2CborDenseMapsCommandOutput extends RpcV2CborDenseMapsInput
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  * @public
  */
 export class RpcV2CborDenseMapsCommand extends $Command

private/smithy-rpcv2-cbor/src/commands/RpcV2CborListsCommand.ts

@@ -131,6 +131,7 @@ export interface RpcV2CborListsCommandOutput extends RpcV2CborListInputOutput, _
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  * @public
  */
 export class RpcV2CborListsCommand extends $Command

private/smithy-rpcv2-cbor/src/commands/RpcV2CborSparseMapsCommand.ts

@@ -94,6 +94,7 @@ export interface RpcV2CborSparseMapsCommandOutput extends RpcV2CborSparseMapsInp
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class RpcV2CborSparseMapsCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/SimpleScalarPropertiesCommand.ts

@@ -71,6 +71,7 @@ export interface SimpleScalarPropertiesCommandOutput extends SimpleScalarStructu
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class SimpleScalarPropertiesCommand extends $Command
   .classBuilder<

private/smithy-rpcv2-cbor/src/commands/SparseNullsOperationCommand.ts

@@ -63,6 +63,7 @@ export interface SparseNullsOperationCommandOutput extends SparseNullsOperationI
  * @throws {@link RpcV2ProtocolServiceException}
  * <p>Base exception class for all service exceptions from RpcV2Protocol service.</p>
  *
+ *
  */
 export class SparseNullsOperationCommand extends $Command
   .classBuilder<