Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Increase the Slot Hash Limit #37

Open
2 tasks
iamrecursion opened this issue Jun 22, 2023 · 0 comments
Open
2 tasks

[TASK] Increase the Slot Hash Limit #37

iamrecursion opened this issue Jun 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@iamrecursion
Copy link
Contributor

Description

Currently the analyzer generates the keccak hashes of the first 1000 storage slots in order to help with slot identification.

According to @thevaizman, some contracts have quite large static arrays > 1000 elements, so we likely need to calculate more slots to be safe. During a meeting I proposed 10 million, but upon thinking about it that causes a residency of approximately 4GB just for the hashes. 1 million is approx. 400MB.

Either way, if we want to increase the limit this much, we should work on a way to retain this data between runs so we don't have to compute it at every start up.

Spec

  • Work out how to handle this.
  • Implement the solution.
@iamrecursion iamrecursion added the enhancement New feature or request label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant