Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace steem with smoke? #10

Open
smoke-indica opened this issue May 8, 2019 · 3 comments
Open

Replace steem with smoke? #10

smoke-indica opened this issue May 8, 2019 · 3 comments

Comments

@smoke-indica
Copy link
Contributor

Expected behavior

smoke-js refers to the smoke network in code and documentation

Actual behavior

smoke-js refers to the steem network in code and documentation

How to reproduce

N/A

Environment information

N/A

@horsecoin
Copy link

horsecoin commented May 10, 2019

I was wondering the same exact thing! How did you end up using for your site, just saw your post about smoke-js, led me here! I used this for steem the other night and worked great, bot sure how to use with smoke yet, but have not investigated. I would assume we clone this, swap out steem for smoke, then use use library same way??

@smoke-indica
Copy link
Contributor Author

I was able to just declare it with the smoke variable name, we should at least update the documentation titles and stuff to reflect smoke though.

@herbncrypto
Copy link

I get what you mean, but it still references the smoke network, as long as you use:
steem.api.setOptions({ url: **'https://rpc.smoke.io'** });

I was curious about it too, but since smoke is a clone of steem, its likely that a lot of the original placeholders remain the same in the source. For instance if you go to http://smoke.io/@herbncrypto.json
when it parses out the info, read through and you can see some remnants of steem code like reward_vesting_steem":"15.753 SMOKE"
and
"reward_steem_balance":"0.000 SMOKE"

I still agree though, maybe make the screenshots atleast resemble smoke.io or at the bottom reference smoke.io instead of steemit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants