Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket error registration and processing #963

Open
cavivie opened this issue Jul 31, 2024 · 2 comments
Open

Socket error registration and processing #963

cavivie opened this issue Jul 31, 2024 · 2 comments

Comments

@cavivie
Copy link

cavivie commented Jul 31, 2024

ICMP should register the error to the corresponding socket when it finds an error likes an unreachable address error. Currently, there is no error handling bound to the socket. In the Linux kernel, this is done by calling back the corresponding socket net protocol when an error is found in ICMP. For example, TCP/UDP/... error handlers will further bind the error to the socket structure based on information such as the four-tuple address. Should we consider this measure? The lack of it will make send/recv and other APIs unable to check errors such as unreachable addresses.

@whitequark
Copy link
Contributor

ICMP should register the error to the corresponding socket when it finds an error likes an unreachable address error. Currently, there is no error handling bound to the socket.

Given that ICMP is purely advisory and it's often just dropped in real networks, I feel like it may not be worth the implementation/maintenance effort. I'm not opposed to it, to be clear, I'm just not sure if the effort/benefit ratio is there.

@whitequark whitequark reopened this Aug 6, 2024
@whitequark
Copy link
Contributor

Er, didn't mean to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants