switch the repo's analysis options to using package:lints (flutter#5534)

switch the repo analysis options to using package:lints

Author: devoncarew

analysis_options.yaml

@@ -1,3 +1,5 @@
+include: package:lints/recommended.yaml
+
 analyzer:
   strong-mode:
     implicit-casts: false
@@ -7,6 +9,5 @@ analyzer:
 
 linter:
   rules:
-    - prefer_single_quotes
-    - type_annotate_public_apis
+    - directives_ordering
     - unawaited_futures

pubspec.yaml

@@ -11,4 +11,5 @@ dependencies:
 dev_dependencies:
   grinder: ^0.9.0
   http: ^0.13.0
+  lints: ^1.0.0
   meta: any

testData/sample_tests/pubspec.yaml

@@ -6,5 +6,6 @@ environment:
   sdk: '>=2.0.0-dev <3.0.0'
 
 dev_dependencies:
+  lints: ^1.0.0
   meta: any
   test: ^1.16.0

tool/grind.dart

@@ -13,7 +13,7 @@ void main(List<String> args) => grind(args);
 void checkUrls() async {
   log('checking URLs in FlutterBundle.properties...');
   var lines =
-      await new File('src/io/flutter/FlutterBundle.properties').readAsLines();
+      await File('src/io/flutter/FlutterBundle.properties').readAsLines();
   for (var line in lines) {
     var split = line.split('=');
     if (split.length == 2) {
@@ -40,7 +40,7 @@ void outlineIcons() async {
 
   for (File file in previewIconsDir
       .listSync()
-      .where((entity) => entity is File)
+      .whereType<File>()
       .cast<File>()
       .where((file) => file.path.endsWith('.svg'))) {
     log('processing ${file.path}...');
@@ -58,7 +58,7 @@ void _createPng(
   File sourceSvg,
   String targetName, {
   required int? size,
-  bool forLight: false,
+  bool forLight = false,
 }) {
   File targetFile = joinFile(sourceSvg.parent, [targetName]);
 

tool/plugin/analysis_options.yaml

@@ -1,17 +1,6 @@
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
+include: package:lints/recommended.yaml
+
 linter:
   rules:
-    - await_only_futures
-    - cancel_subscriptions
     - directives_ordering
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - omit_local_variable_types
-    - prefer_final_fields
-    - test_types_in_equals
-    - type_annotate_public_apis
-    - type_init_formals
     - unawaited_futures
-    - unrelated_type_equality_checks
-    - valid_regexps

tool/plugin/lib/artifact.dart

@@ -16,10 +16,8 @@ class Artifact {
   final bool bareArchive;
   String output;
 
-  Artifact(this.file, {this.bareArchive: false, this.output}) {
-    if (output == null) {
-      output = file.substring(0, file.lastIndexOf('-'));
-    }
+  Artifact(this.file, {this.bareArchive = false, this.output}) {
+    output ??= file.substring(0, file.lastIndexOf('-'));
   }
 
   bool get isZip => file.endsWith('.zip');

tool/plugin/lib/build_spec.dart

@@ -36,12 +36,11 @@ class BuildSpec {
   Artifact product;
   Artifact dartPlugin;
 
-  BuildSpec.fromJson(Map json, String releaseNum)
-      : release = releaseNum,
-        name = json['name'],
+  BuildSpec.fromJson(Map json, this.release)
+      : name = json['name'],
         channel = json['channel'],
         version = json['version'],
-        ijVersion = json['ijVersion'] ?? null,
+        ijVersion = json['ijVersion'],
         ideaProduct = json['ideaProduct'],
         ideaVersion = json['ideaVersion'],
         dartPluginVersion = json['dartPluginVersion'],
@@ -103,7 +102,8 @@ class BuildSpec {
               // We only put Linux versions in cloud storage.
               artifacts.add(Artifact('$ideaProduct-$ideaVersion-linux.tar.gz',
                   output: ideaProduct));
-              artifacts.add(Artifact('$ideaProduct-ide-$ideaVersion-linux.tar.gz',
+              artifacts.add(Artifact(
+                  '$ideaProduct-ide-$ideaVersion-linux.tar.gz',
                   output: ideaProduct));
             }
           }
@@ -137,6 +137,7 @@ class BuildSpec {
         .replaceAll('</p>', '');
   }
 
+  @override
   String toString() {
     return 'BuildSpec($ideaProduct $ideaVersion $dartPluginVersion $sinceBuild '
         '$untilBuild version: "$release")';
@@ -175,13 +176,15 @@ class SyntheticBuildSpec extends BuildSpec {
     try {
       // 'isUnitTestTarget' should always be in the spec for the latest IntelliJ (not AS).
       alternate = specs.firstWhere((s) => s.isUnitTestTarget);
-    } catch (StateError) {
+    } on StateError catch (_) {
       log('No build spec defines "isUnitTestTarget"');
       exit(1);
     }
   }
 
+  @override
   String get untilBuild => alternate.untilBuild;
 
+  @override
   bool get isSynthetic => true;
 }

tool/plugin/lib/edit.dart

@@ -9,6 +9,8 @@
 import 'dart:async';
 import 'dart:io';
 
+import 'package:meta/meta.dart';
+
 import 'build_spec.dart';
 import 'util.dart';
 
@@ -20,7 +22,9 @@ void checkAndClearAppliedEditCommands() {
     commands.addAll(editCommands);
     commands.removeAll(appliedEditCommands);
     separator("UNUSED EditCommand");
-    commands.forEach((cmd) => log(cmd.toString()));
+    for (var cmd in commands) {
+      log(cmd.toString());
+    }
   }
   appliedEditCommands.clear();
 }
@@ -125,10 +129,9 @@ class EditAndroidModuleLibraryManager extends EditCommand {
     // Starting with 3.6 we need to call a simplified init().
     // This is where the $PROJECT_FILE$ macro is defined, #registerComponents.
     if (spec.version.startsWith('4.2')) {
-      var processedFile, source;
-      processedFile = File(
+      var processedFile = File(
           'flutter-studio/src/io/flutter/android/AndroidModuleLibraryManager.java');
-      source = processedFile.readAsStringSync();
+      var source = processedFile.readAsStringSync();
       var original = source;
       source = source.replaceAll("ProjectExImpl", "ProjectImpl");
       source = source.replaceAll(
@@ -170,7 +173,7 @@ Future<int> applyEdits(BuildSpec spec, Function compileFn) async {
       if (entity is File) {
         var stubFile = File('${file}_stub');
         if (stubFile.existsSync()) {
-          await stubFile.copy('$file');
+          await stubFile.copy(file);
           log('copied ${file}_stub');
         }
       }
@@ -179,13 +182,13 @@ Future<int> applyEdits(BuildSpec spec, Function compileFn) async {
 
   var edited = <EditCommand, String>{};
   try {
-    editCommands.forEach((edit) {
+    for (var edit in editCommands) {
       var source = edit.convert(spec);
       if (source != null) {
         edited[edit] = source;
         appliedEditCommands.add(edit);
       }
-    });
+    }
 
     return await compileFn.call();
   } finally {
@@ -231,9 +234,9 @@ class Subst extends EditCommand {
 
   Subst(
       {this.versions,
-      this.initial,
-      this.replacement,
-      this.path,
+      @required this.initial,
+      @required this.replacement,
+      @required this.path,
       String version})
       : assert(initial != null),
         assert(replacement != null),
@@ -260,6 +263,7 @@ class Subst extends EditCommand {
     }
   }
 
+  @override
   String toString() => "Subst(path: $path, versions: $versions)";
 
   bool versionMatches(BuildSpec spec) {
@@ -279,7 +283,7 @@ class MultiSubst extends EditCommand {
     this.versions,
     this.initials,
     this.replacements,
-    this.path,
+    @required this.path,
   }) {
     assert(initials.length == replacements.length);
     assert(path != null);
@@ -303,6 +307,7 @@ class MultiSubst extends EditCommand {
     }
   }
 
+  @override
   String toString() => "Subst(path: $path, versions: $versions)";
 
   bool versionMatches(BuildSpec spec) {

tool/plugin/lib/globals.dart

@@ -4,7 +4,7 @@
 // @dart = 2.10
 
 // Map plugin ID to JetBrains registry ID.
-const Map<String, String> pluginRegistryIds = const {
+const Map<String, String> pluginRegistryIds = {
   'io.flutter': '9212',
   'io.flutter.as': '10139', // Currently unused.
 };

tool/plugin/lib/lint.dart

@@ -12,15 +12,19 @@ import 'runner.dart';
 import 'util.dart';
 
 class LintCommand extends Command {
+  @override
   final BuildCommandRunner runner;
 
   LintCommand(this.runner);
 
+  @override
   String get name => 'lint';
 
+  @override
   String get description =>
       'Perform simple validations on the flutter-intellij repo code.';
 
+  @override
   Future<int> run() async {
     // Check for unintentionally imported annotations.
     if (checkForBadImports()) {
@@ -70,7 +74,9 @@ class LintCommand extends Command {
     for (var import in keys) {
       print('$import:');
       var places = usages[import];
-      places.forEach((String place) => print('  $place'));
+      for (var place in places) {
+        print('  $place');
+      }
       print('');
     }
   }