Skip to content

Commit afcadc5

Browse files
committed
scripts/mergeOutput.py - added two todo items
1 parent 36fb1b7 commit afcadc5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

workflow/scripts/mergeOutput.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
outFile = snakemake.output[0]
66
inFiles = snakemake.input
77

8+
#TODO: change to ZIPFILE to support better result portability
89
with open(outFile, 'wb') as outF:
910
for file in inFiles:
1011
try:
1112
out = subprocess.check_output(['gunzip', '-t', file]) #test if gzip file is valid before merging
1213

14+
#TODO: avoid overwriting the file descriptor!
1315
with open(file, 'rb') as sourceFile:
1416
shutil.copyfileobj(sourceFile, outF)
1517
except subprocess.CalledProcessError:

0 commit comments

Comments
 (0)