fix: failing unit tests on server

Author: acke

plugin/src/main/java/io/snyk/eclipse/plugin/Activator.java

@@ -46,7 +46,14 @@ public static Activator getDefault() {
 	 * @return the image descriptor
 	 */
 	public static ImageDescriptor getImageDescriptor(String key) {
-		return getDefault().getImageRegistry().getDescriptor(key);
+		ImageRegistry imageRegistry = getDefault().getImageRegistry();
+
+		if (imageRegistry == null) {
+			return ImageDescriptor.getMissingImageDescriptor();
+
+		}
+
+		return imageRegistry.getDescriptor(key);
 	}
 
 	@Override

tests/src/test/java/io/snyk/languageserver/LsBaseTest.java

@@ -1,5 +1,6 @@
 package io.snyk.languageserver;
 
+import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.clearAllCaches;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -8,51 +9,60 @@
 import java.io.IOException;
 
 import org.eclipse.core.net.proxy.IProxyService;
+import org.eclipse.jface.resource.ImageRegistry;
+import org.eclipse.swt.graphics.Image;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
 
 import io.snyk.eclipse.plugin.preferences.InMemoryPreferenceStore;
 import io.snyk.eclipse.plugin.preferences.Preferences;
 import io.snyk.eclipse.plugin.properties.preferences.PreferencesUtils;
 
 public class LsBaseTest {
-  protected LsRuntimeEnvironment environment = null;
-  protected IProxyService proxyServiceMock;
-
-  private File lsFile = getTempFile();
-
-  @BeforeEach
-  protected void setUp() {
-    clearAllCaches();
-    if (lsFile.exists())
-      lsFile.delete();
-    lsFile = getTempFile();
-    environment = mock(LsRuntimeEnvironment.class);
-    InMemoryPreferenceStore store = new InMemoryPreferenceStore();
-    Preferences prefs = Preferences.getInstance(store);
-	PreferencesUtils.setPreferences(prefs);
-    prefs.setTest(true);
-
-    when(environment.getArch()).thenReturn("amd64");
-    when(environment.getOs()).thenReturn("linux");
-    when(environment.getDownloadBinaryName()).thenReturn("snyk-ls_testVersion_linux_amd64");
-    proxyServiceMock = mock(IProxyService.class);
-    when(environment.getProxyService()).thenReturn(proxyServiceMock);
-  }
-
-  @AfterEach
-  protected void tearDown() {
-    lsFile.delete();
-    clearAllCaches();
-  }
-
-  protected File getTempFile() {
-    try {
-      File tempFile = File.createTempFile("ls-test", "tmp");
-      tempFile.deleteOnExit();
-      return tempFile;
-    } catch (IOException e) {
-      throw new RuntimeException(e);
-    }
-  }
+	protected LsRuntimeEnvironment environment = null;
+	protected IProxyService proxyServiceMock;
+
+	private File lsFile = getTempFile();
+	@Mock
+	private ImageRegistry imageRegistry;
+
+	@BeforeEach
+	protected void setUp() {
+		clearAllCaches();
+		if (lsFile.exists())
+			lsFile.delete();
+		lsFile = getTempFile();
+		environment = mock(LsRuntimeEnvironment.class);
+		InMemoryPreferenceStore store = new InMemoryPreferenceStore();
+		Preferences prefs = Preferences.getInstance(store);
+		PreferencesUtils.setPreferences(prefs);
+		prefs.setTest(true);
+
+		MockitoAnnotations.openMocks(this);
+		when(imageRegistry.get(anyString())).thenReturn(mock(Image.class));
+
+		when(environment.getArch()).thenReturn("amd64");
+		when(environment.getOs()).thenReturn("linux");
+		when(environment.getDownloadBinaryName()).thenReturn("snyk-ls_testVersion_linux_amd64");
+		proxyServiceMock = mock(IProxyService.class);
+		when(environment.getProxyService()).thenReturn(proxyServiceMock);
+	}
+
+	@AfterEach
+	protected void tearDown() {
+		lsFile.delete();
+		clearAllCaches();
+	}
+
+	protected File getTempFile() {
+		try {
+			File tempFile = File.createTempFile("ls-test", "tmp");
+			tempFile.deleteOnExit();
+			return tempFile;
+		} catch (IOException e) {
+			throw new RuntimeException(e);
+		}
+	}
 }