Skip to content

Commit 83c7042

Browse files
ioquatixioquatix
committed
Modernize gem.
1 parent 061817e commit 83c7042

File tree

16 files changed

+80
-74
lines changed

16 files changed

+80
-74
lines changed

‎.github/workflows/test-coverage.yaml

+4-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@ jobs:
3434
timeout-minutes: 5
3535
run: bundle exec bake test
3636

37-
- uses: actions/upload-artifact@v3
37+
- uses: actions/upload-artifact@v4
3838
with:
39+
include-hidden-files: true
40+
if-no-files-found: error
3941
name: coverage-${{matrix.os}}-${{matrix.ruby}}
4042
path: .covered.db
4143

@@ -50,7 +52,7 @@ jobs:
5052
ruby-version: "3.3"
5153
bundler-cache: true
5254

53-
- uses: actions/download-artifact@v3
55+
- uses: actions/download-artifact@v4
5456

5557
- name: Validate coverage
5658
timeout-minutes: 5

‎.rubocop.yml

+4
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,7 @@ Layout/EmptyLinesAroundModuleBody:
4747

4848
Style/FrozenStringLiteralComment:
4949
Enabled: true
50+
51+
Style/StringLiterals:
52+
Enabled: true
53+
EnforcedStyle: double_quotes

‎async-pool.gemspec

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ Gem::Specification.new do |spec|
1010
spec.authors = ["Samuel Williams", "Olle Jonsson", "Simon Perepelitsa", "Thomas Morgan"]
1111
spec.license = "MIT"
1212

13-
spec.cert_chain = ['release.cert']
14-
spec.signing_key = File.expand_path('~/.gem/release.pem')
13+
spec.cert_chain = ["release.cert"]
14+
spec.signing_key = File.expand_path("~/.gem/release.pem")
1515

1616
spec.homepage = "https://github.com/socketry/async-pool"
1717

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
2121
"source_code_uri" => "https://github.com/socketry/async-pool.git",
2222
}
2323

24-
spec.files = Dir.glob(['{lib}/**/*', '*.md'], File::FNM_DOTMATCH, base: __dir__)
24+
spec.files = Dir.glob(["{lib}/**/*", "*.md"], File::FNM_DOTMATCH, base: __dir__)
2525

2626
spec.required_ruby_version = ">= 3.1"
2727

‎config/sus.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
# Released under the MIT License.
4-
# Copyright, 2022, by Samuel Williams.
4+
# Copyright, 2022-2024, by Samuel Williams.
55

6-
require 'covered/sus'
6+
require "covered/sus"
77
include Covered::Sus

‎examples/memory/gems.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# frozen_string_literal: true
22

33
# Released under the MIT License.
4-
# Copyright, 2022, by Samuel Williams.
4+
# Copyright, 2022-2024, by Samuel Williams.
55

6-
source 'https://rubygems.org'
6+
source "https://rubygems.org"
77

88
gem "async"
99
gem "async-redis"

‎examples/overhead/connect.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
# frozen_string_literal: true
33

44
# Released under the MIT License.
5-
# Copyright, 2021-2022, by Samuel Williams.
5+
# Copyright, 2021-2024, by Samuel Williams.
66

7-
require 'async'
7+
require "async"
88

9-
require 'async/pool/controller'
10-
require 'async/pool/resource'
9+
require "async/pool/controller"
10+
require "async/pool/resource"
1111

1212
class MyResource < Async::Pool::Resource
1313
def self.call

‎examples/overhead/gems.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# frozen_string_literal: true
22

33
# Released under the MIT License.
4-
# Copyright, 2021-2022, by Samuel Williams.
4+
# Copyright, 2021-2024, by Samuel Williams.
55

6-
source 'https://rubygems.org'
6+
source "https://rubygems.org"
77

88
# Takes about ~10s
99
# gem "async-pool", "0.3.3"

‎fixtures/nonblocking_resource.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# frozen_string_literal: true
22

33
# Released under the MIT License.
4-
# Copyright, 2021-2023, by Samuel Williams.
4+
# Copyright, 2021-2024, by Samuel Williams.
55

6-
require 'async/pool/controller'
7-
require 'async/pool/resource'
6+
require "async/pool/controller"
7+
require "async/pool/resource"
88

99
class Async::Pool::Controller
1010
attr :available

‎gems.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Released under the MIT License.
44
# Copyright, 2019-2024, by Samuel Williams.
55

6-
source 'https://rubygems.org'
6+
source "https://rubygems.org"
77

88
gemspec
99

‎lib/async/pool.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
# Released under the MIT License.
44
# Copyright, 2019-2024, by Samuel Williams.
55

6-
require_relative 'pool/version'
7-
require_relative 'pool/controller'
6+
require_relative "pool/version"
7+
require_relative "pool/controller"
88

99
# @namespace
1010
module Async

‎lib/async/pool/controller.rb

+11-11
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
# Copyright, 2020, by Simon Perepelitsa.
66
# Copyright, 2024, by Thomas Morgan.
77

8-
require 'console/logger'
8+
require "console/logger"
99

10-
require 'async'
11-
require 'async/notification'
12-
require 'async/semaphore'
10+
require "async"
11+
require "async/notification"
12+
require "async/semaphore"
1313

14-
require 'traces'
15-
require 'metrics'
14+
require "traces"
15+
require "metrics"
1616

1717
module Async
1818
module Pool
@@ -396,7 +396,7 @@ def create_resource(...)
396396
tags: @tags,
397397
}
398398

399-
Traces.trace('async.pool.create', attributes: attributes) {super}
399+
Traces.trace("async.pool.create", attributes: attributes) {super}
400400
end
401401

402402
def drain(...)
@@ -405,14 +405,14 @@ def drain(...)
405405
tags: @tags,
406406
}
407407

408-
Traces.trace('async.pool.drain', attributes: attributes) {super}
408+
Traces.trace("async.pool.drain", attributes: attributes) {super}
409409
end
410410
end
411411

412412
Metrics::Provider(self) do
413-
ACQUIRE_COUNT = Metrics.metric('async.pool.acquire', :counter, description: 'Number of times a resource was invoked.')
414-
RELEASE_COUNT = Metrics.metric('async.pool.release', :counter, description: 'Number of times a resource was released.')
415-
RETIRE_COUNT = Metrics.metric('async.pool.retire', :counter, description: 'Number of times a resource was retired.')
413+
ACQUIRE_COUNT = Metrics.metric("async.pool.acquire", :counter, description: "Number of times a resource was invoked.")
414+
RELEASE_COUNT = Metrics.metric("async.pool.release", :counter, description: "Number of times a resource was released.")
415+
RETIRE_COUNT = Metrics.metric("async.pool.retire", :counter, description: "Number of times a resource was retired.")
416416

417417
def acquire(...)
418418
ACQUIRE_COUNT.emit(1, tags: @tags)

‎lib/async/pool/resource.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
# Released under the MIT License.
44
# Copyright, 2019-2024, by Samuel Williams.
55

6-
require 'console/logger'
6+
require "console/logger"
77

8-
require 'async/notification'
9-
require 'async/semaphore'
8+
require "async/notification"
9+
require "async/semaphore"
1010

1111
module Async
1212
module Pool

‎test/async/pool.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# frozen_string_literal: true
22

33
# Released under the MIT License.
4-
# Copyright, 2022, by Samuel Williams.
4+
# Copyright, 2022-2024, by Samuel Williams.
55

6-
require 'async/pool'
6+
require "async/pool"
77

88
describe Async::Pool do
99
it "has a version number" do

0 commit comments

Comments
 (0)