Tidy up environment variable usage.

Author: ioquatix

.github/workflows/test-coverage.yaml

@@ -19,33 +19,35 @@ jobs:
         include:
           - os: ubuntu
             ruby: "3.1"
-            selector: EPoll
+            io_event_selector: EPoll
           - os: ubuntu
             ruby: "3.2"
-            selector: EPoll
+            io_event_selector: EPoll
           - os: ubuntu
             ruby: "3.3"
-            selector: EPoll
+            io_event_selector: EPoll
           - os: ubuntu
             ruby: "3.4"
-            selector: EPoll
+            io_event_selector: EPoll
           - os: ubuntu
             ruby: "3.4"
-            selector: URing
+            io_event_selector: URing
           - os: ubuntu
             ruby: "3.4"
-            selector: URing
-            fiber_profile_capture: "true"
+            io_event_selector: URing
+            fiber_profiler_capture: "true"
           - os: ubuntu
             ruby: "head"
-            selector: URing
+            io_event_selector: URing
           - os: ubuntu
             ruby: "head"
-            selector: URing
-            worker_pool: "true"
+            io_event_selector: URing
+            async_scheduler_worker_pool: "true"
 
     env:
-      FIBER_PROFILER_CAPTURE: ${{matrix.fiber_profile_capture}}
+      IO_EVENT_SELECTOR: ${{matrix.io_event_selector}}
+      ASYNC_SCHEDULER_WORKER_POOL: ${{matrix.async_scheduler_worker_pool}}
+      FIBER_PROFILER_CAPTURE: ${{matrix.fiber_profiler_capture}}
 
     steps:
     - uses: actions/checkout@v4
@@ -58,17 +60,13 @@ jobs:
 
     - name: Run tests
       timeout-minutes: 5
-      env:
-        IO_EVENT_SELECTOR: ${{matrix.selector}}
-        ASYNC_SCHEDULER_DEFAULT_WORKER_POOL: ${{matrix.worker_pool}}
-        FIBER_PROFILER_CAPTURE: ${{matrix.fiber_profile_capture}}
       run: bundle exec bake test
 
     - uses: actions/upload-artifact@v4
       with:
         include-hidden-files: true
         if-no-files-found: error
-        name: coverage-${{matrix.os}}-${{matrix.ruby}}-${{matrix.selector}}-${{matrix.worker_pool}}-${{matrix.fiber_profile_capture}}
+        name: coverage-${{matrix.os}}-${{matrix.ruby}}-${{matrix.io_event_selector}}-${{matrix.async_scheduler_worker_pool}}-${{matrix.fiber_profiler_capture}}
         path: .covered.db
 
   validate:

.github/workflows/test-worker-pool.yaml

@@ -7,11 +7,11 @@ permissions:
 
 env:
   CONSOLE_OUTPUT: XTerm
-  ASYNC_SCHEDULER_DEFAULT_WORKER_POOL: true
+  ASYNC_SCHEDULER_WORKER_POOL: true
 
 jobs:
   test:
-    name: ${{matrix.ruby}} on ${{matrix.os}} / ASYNC_SCHEDULER_DEFAULT_WORKER_POOL=true
+    name: ${{matrix.ruby}} on ${{matrix.os}} / ASYNC_SCHEDULER_WORKER_POOL=true
     runs-on: ${{matrix.os}}-latest
 
     strategy:

lib/async/scheduler.rb

@@ -25,7 +25,7 @@ module Async
 
 	# Handles scheduling of fibers. Implements the fiber scheduler interface.
 	class Scheduler < Node
-		DEFAULT_WORKER_POOL = ENV.fetch("ASYNC_SCHEDULER_DEFAULT_WORKER_POOL", nil).then do |value|
+		WORKER_POOL = ENV.fetch("ASYNC_SCHEDULER_WORKER_POOL", nil).then do |value|
 			value == "true" ? true : nil
 		end
 
@@ -50,7 +50,7 @@ def self.supported?
 		# @public Since *Async v1*.
 		# @parameter parent [Node | Nil] The parent node to use for task hierarchy.
 		# @parameter selector [IO::Event::Selector] The selector to use for event handling.
-		def initialize(parent = nil, selector: nil, profiler: Profiler&.default, worker_pool: DEFAULT_WORKER_POOL)
+		def initialize(parent = nil, selector: nil, profiler: Profiler&.default, worker_pool: WORKER_POOL)
 			super(parent)
 
 			@selector = selector || ::IO::Event::Selector.new(Fiber.current)

releases.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+  - Rename `ASYNC_SCHEDULER_DEFAULT_WORKER_POOL` to `ASYNC_SCHEDULER_WORKER_POOL`.
+
 ### Fiber Stall Profiler
 
 After several iterations of experimentation, we are officially introducing the fiber stall profiler, implemented using the optional `fiber-profiler` gem. This gem is not included by default, but can be added to your project:
@@ -30,7 +32,7 @@ Ruby 3.4 will feature a new fiber scheduler hook, `blocking_operation_wait` whic
 
 The Async scheduler optionally supports this feature using a worker pool, by using the following environment variable:
 
-    ASYNC_SCHEDULER_DEFAULT_WORKER_POOL=true
+    ASYNC_SCHEDULER_WORKER_POOL=true
 
 This will cause the scheduler to use a worker pool for general blocking operations, rather than blocking the event loop.