Revert "Introduce option requires_masking to Framer for enforcing masking."

This reverts commit afe247a.

Author: ioquatix

lib/protocol/websocket/frame.rb

@@ -23,7 +23,6 @@ class Frame
 			# @parameter mask [Boolean | String] An optional 4-byte string which is used to mask the payload.
 			def initialize(finished = true, payload = nil, flags: 0, opcode: self.class::OPCODE, mask: false)
 				if mask == true
-					# Generate a unique mask for each frame:
 					mask = SecureRandom.bytes(4)
 				end
 

lib/protocol/websocket/framer.rb

@@ -29,11 +29,9 @@ module WebSocket
 
 		# Wraps an underlying {Async::IO::Stream} for reading and writing binary data into structured frames.
 		class Framer
-			def initialize(stream, frames = FRAMES, requires_masking: false)
+			def initialize(stream, frames = FRAMES)
 				@stream = stream
 				@frames = frames
-				
-				@requires_masking = requires_masking
 			end
 
 			# Close the underlying stream.
@@ -56,10 +54,6 @@ def read_frame(maximum_frame_size = MAXIMUM_ALLOWED_FRAME_SIZE)
 				klass = @frames[opcode] || Frame
 				frame = klass.read(finished, flags, opcode, @stream, maximum_frame_size)
 
-				if @requires_masking and !frame.mask
-					raise ProtocolError, "Received unmasked frame but requires masking!"
-				end
-				
 				return frame
 			end
 

test/protocol/websocket/framer.rb

@@ -16,19 +16,4 @@
 			end.to raise_exception(EOFError, message: be =~ /Could not read frame header/)
 		end
 	end
-	
-	with "requires_masking: true" do
-		let(:framer) {subject.new(stream, requires_masking: true)}
-		
-		it "fails if it receives an unmasked frame" do
-			frame = Protocol::WebSocket::BinaryFrame.new(true).pack("Hello, World!")
-			frame.write(stream)
-			
-			stream.rewind
-			
-			expect do
-				framer.read_frame
-			end.to raise_exception(Protocol::WebSocket::ProtocolError, message: be =~ /Received unmasked frame but requires masking!/)
-		end
-	end
 end