Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In push_prometheus_alert function using http protocol can be insecure #874

Open
vineela1999 opened this issue Apr 12, 2022 · 0 comments
Open

Comments

@vineela1999
Copy link
Contributor

Issue/Feature Description:
In delfin/exporter/prometheus/alert_manager.py,
In the function definition,
def push_prometheus_alert(self, alerts):

try:
                response = requests.post('http://' + host + ":" + port +
                                         '/api/v1/alerts',
                                         json=self.alerts)
                if response.status_code != 200:

here using Http protocol can be insecure

Why this issue to fixed / feature is needed(give scenarios or use cases):
Using Http protocol can be insecure . Https can be used instead
How to reproduce, in case of a bug:

Other Notes / Environment Information: (Please give the env information, log link or any useful information for this issue)

UtkarshShah0 added a commit to UtkarshShah0/delfin that referenced this issue Apr 24, 2022
In push_prometheus_alert function replaced http with https to make it more secure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant