Commit 5b4eef0
authored
[RNE Rewrite] fix(example): add bottom safe area inset to classification screen (#1299)
## Description
Follow-up PR to two problems raised in review of #1296
-
#1296 (comment)
-
#1296 (comment)
It
- Fixes the classification example screen to not overlap with Android
navigation buttons.
- Leaves the default YOLO threshold as `0.25` since it is the official
recommended default value (see: [ultralytics
docs](https://docs.ultralytics.com/modes/predict#fixed-shape-vs-minimum-rectangle-rect:~:text=float-,0.25,-Sets%20the%20minimum))
### Introduces a breaking change?
- [ ] Yes
- [x] No
### Type of change
- [x] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)
### Tested on
- [ ] iOS
- [x] Android
### Testing instructions
- [ ] Run the computer-vision app on Android and confirm that there is
no overlap with navigation buttons.
### Screenshots
<!-- Add screenshots here, if applicable -->
### Related issues
<!-- Link related issues here using #issue-number -->
### Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have updated the documentation accordingly
- [x] My changes generate no new warnings
### Additional notes
<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->1 parent 7b6446d commit 5b4eef0
1 file changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
97 | 99 | | |
98 | 100 | | |
99 | 101 | | |
100 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
101 | 106 | | |
102 | 107 | | |
103 | 108 | | |
| |||
0 commit comments