Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Going back to previous screen disables interactions with Touchables with @react-navigation/bottom-tabs #2150

Open
tboba opened this issue May 20, 2024 · 2 comments
Assignees
Labels
NewArch Issues related only to new architecture Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided

Comments

@tboba
Copy link
Member

tboba commented May 20, 2024

Description

Currently, on new architecture while using @react-navigation/bottom-tabs, while going to another screen and going back to previous one, interaction with all of touchables is frozen. This seems to be only the case for touchables though, since animations are working as usual (you can see on the preview shown below, that animations are working as usual).

Blocked interaction - Fabric
8mb.video-8hf-qIzZnnk6.mp4
(Not) blocked interaction - Paper
Screen.Recording.2024-05-20.at.16.34.15.mov
(Not) blocked interaction - Paper - without bottom tabs
Screen.Recording.2024-05-20.at.16.49.59.mov
(Not) blocked interaction - Paper - with detachInactiveScreens disabled
Screen.Recording.2024-05-20.at.16.51.06.mov

Steps to reproduce

  1. Create a bottom tab navigator with two screens,
  2. Create on both screens touchables with navigating to one screen and coming back with goBack operation,
  3. Try to run the example with new architecture enabled,
  4. Try to navigate to another screen and press touchable on the second screen to go back,
  5. You shouldn't be able to navigate to another screen with touchable now.

You can run Test645 and Test691 to reproduce this scenario.

Snack or a link to a repository

https://snack.expo.dev/@tboba/5bc06c

Screens version

3.31.1

React Native version

0.74.1

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

Debug mode

Device

Android emulator

Device model

Pixel 7 Pro (API 34)

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided labels May 20, 2024
@tboba tboba added the NewArch Issues related only to new architecture label May 20, 2024
@tboba tboba self-assigned this Jul 18, 2024
@tboba tboba assigned alduzy and unassigned tboba Aug 1, 2024
@alduzy
Copy link
Member

alduzy commented Aug 7, 2024

Inspired by #1975 (comment) I found out that using RectButton from react-native-gesture-handler does work in this case as well.

@hosseinmd
Copy link

I have a crash when going back from bottom-tabs

This is my error log

java.lang.IllegalStateException: addViewAt: cannot insert view [80] into parent [82]: View already has a parent: [-1]  Parent: ScreensFrameLayout View: Screen
                                                                                                    	at com.facebook.react.fabric.mounting.SurfaceMountingManager.addViewAt(SurfaceMountingManager.java:384)

@alduzy alduzy assigned kkafar and unassigned alduzy Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewArch Issues related only to new architecture Platform: Android This issue is specific to Android Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

4 participants