fix(http): sendWebResponse settles when the client disconnects during backpressure — the 'drain' wait had no other way to resolve, but a closed response never emits 'drain', so every streamed response aborted mid-stream leaked its promise chain, reader, and Response for the rest of the dev/preview session; the wait now races 'close'/'error' and the loop bails once the response is destroyed (#303)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: brenelz

.changeset/send-web-response-drain-hang.md

@@ -0,0 +1,5 @@
+---
+'vite-plugin-solid': patch
+---
+
+`sendWebResponse` no longer hangs forever when a client disconnects during backpressure. The write loop's `'drain'` wait had no other way to settle, but a response whose client already went away never emits `'drain'` — so every streamed SSR response aborted mid-stream (closed tab, slow mobile client) parked the promise chain, the body reader, and the Response object permanently, accumulating leaks over a turnkey dev/preview session. The backpressure wait now also settles on `'close'`/`'error'` and the loop bails out early once the response is destroyed, letting the existing close handler's reader cancellation finish cleanup.

src/http.ts

@@ -56,8 +56,27 @@ export async function sendWebResponse(res: ServerResponse, response: Response):
     while (true) {
       const { done, value } = await reader.read();
       if (done) break;
+      // A response whose client already went away never emits 'drain'
+      // (writes are no-ops), so a backpressure wait must also settle on
+      // 'close'/'error' or an aborted streaming response parks this promise
+      // — and the reader and Response it holds — forever.
+      if (res.destroyed) return;
       if (!res.write(value)) {
-        await new Promise((resolve) => res.once('drain', resolve));
+        const drained = await new Promise<boolean>((resolve) => {
+          const settle = (ok: boolean) => {
+            res.off('drain', onDrain);
+            res.off('close', onGone);
+            res.off('error', onGone);
+            resolve(ok);
+          };
+          const onDrain = () => settle(true);
+          const onGone = () => settle(false);
+          res.once('drain', onDrain);
+          res.once('close', onGone);
+          res.once('error', onGone);
+        });
+        // Client gone mid-stream; the 'close' handler cancels the reader.
+        if (!drained) return;
       }
     }
     res.end();