(1.16) [FAIL] Check read only [It] can run a read only check

[bewebi]

Which tests failed?

[FAIL] Check read only [It] can run a read only check

Initial Investigation

https://github.com/solo-io/gloo/actions/runs/10879064457/job/30183059394#step:3:959

Looks like pods were healthy but the test did not expect there to be "Note" text prior to OK
It's not clear whether the solution should be for the test to be more flexible (ie allow there to be additional text between Checking pods... and OK) or for glooctl not to include the "Note" text in output

Check read only [It] can run a read only check
/home/runner/work/gloo/gloo/test/kube2e/glooctl/check_test.go:235

  Timeline >>
  Checking deployments... OK
  Checking pods... Note: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersOK
  Checking upstreams... OK
  Checking upstream groups... OK
  Checking auth configs... OK
  Checking rate limit configs... OK
  Checking VirtualHostOptions... OK
  Checking RouteOptions... OK
  Checking secrets... OK
  Checking virtual services... OK
  Checking gateways... OK
  Checking proxies... OK
  Warning: checking proxies with port forwarding is disabled
  Warning: checking xds with port forwarding is disabled
  No problems detected.
  Skipping Gloo Instance check -- Gloo Federation not detected
  [FAILED] in [It] - /home/runner/work/gloo/gloo/test/kube2e/glooctl/check_test.go:240 @ 09/16/24 07:19:58.775
  << Timeline

  [FAILED] Expected
      <string>: Checking deployments... OK
      Checking pods... Note: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersNote: Unhandled pod condition PodReadyToStartContainersOK
      Checking upstreams... OK
      Checking upstream groups... OK
      Checking auth configs... OK
      Checking rate limit configs... OK
      Checking VirtualHostOptions... OK
      Checking RouteOptions... OK
      Checking secrets... OK
      Checking virtual services... OK
      Checking gateways... OK
      Checking proxies... OK
      Warning: checking proxies with port forwarding is disabled
      Warning: checking xds with port forwarding is disabled
      No problems detected.
      Skipping Gloo Instance check -- Gloo Federation not detected
      
  to contain substring
      <string>: Checking pods... OK
  In [It] at: /home/runner/work/gloo/gloo/test/kube2e/glooctl/check_test.go:240 @ 09/16/24 07:19:58.775

  Full Stack Trace
    github.com/solo-io/gloo/test/kube2e/glooctl_test.glob..func2.3.2()
    	/home/runner/work/gloo/gloo/test/kube2e/glooctl/check_test.go:240 +0x2aa

Additional Information

No response

[inFocus7]

Caught here as well: https://github.com/solo-io/gloo/actions/runs/10989284934/job/30507211260#step:3:955

[jenshu]

https://github.com/solo-io/gloo/actions/runs/11101106865/job/30838159200