Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set GOMAXPROCS and GOMEMLIMIT #10062

Open
jenshu opened this issue Sep 18, 2024 · 0 comments
Open

Automatically set GOMAXPROCS and GOMEMLIMIT #10062

jenshu opened this issue Sep 18, 2024 · 0 comments
Assignees
Labels
Area: Gloo Gateway Issues related to the Gloo Gateway project Prioritized Indicating issue prioritized to be worked on in RFE stream Type: Enhancement New feature or request

Comments

@jenshu
Copy link
Contributor

jenshu commented Sep 18, 2024

Gloo Edge Product

Open Source

Gloo Edge Version

1.17

Is your feature request related to a problem? Please describe.

It is good practice to set the Go runtime environment variables GOMAXPROCS and GOMEMLIMIT, which tell Go the max threads/memory it should use. We should set these in our containers that run Go (namely gloo and discovery) whenever resource limits are set.

See:
https://pkg.go.dev/runtime
https://blog.howardjohn.info/posts/gomaxprocs/

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

@jenshu jenshu added the Type: Enhancement New feature or request label Sep 18, 2024
@jenshu jenshu self-assigned this Sep 18, 2024
@jenshu jenshu added Area: Gloo Gateway Issues related to the Gloo Gateway project Prioritized Indicating issue prioritized to be worked on in RFE stream labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Gloo Gateway Issues related to the Gloo Gateway project Prioritized Indicating issue prioritized to be worked on in RFE stream Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant