Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Release tags aren't reachable from main #46404

Closed
sqs opened this issue Jan 13, 2023 · 0 comments
Closed

Release tags aren't reachable from main #46404

sqs opened this issue Jan 13, 2023 · 0 comments

Comments

@sqs
Copy link
Member

sqs commented Jan 13, 2023

How we use Git tags changed at v4.0.0-rc.1. As a result, git describe reports v4.0.0-rc.1-2698-gd7335437dc (expected: something like v4.3.1-NNNN-...).

The reason is that the tagged commits for each release are no longer commits that are reachable from main (i.e., we tag commits that are branched off from main on release branches).

I see why this is done, and it makes sense. But some tools assume git describe output is meaningful, and it no longer is with this approach (which causes problems with a tool I'm using to publish binary builds of Sourcegraph App, goreleaser). I can work around it easily.

I just wanted to mention this in case anyone else is confused and searches our issue tracker about this problem.

@sqs sqs closed this as completed Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant