Skip to content

Revisit TODO in match2ref #237

@pllim

Description

@pllim

I stumbled upon this

tweakwcs/tweakwcs/wcsimage.py

Lines 1017 to 1029 in 4ddf4b1

# TODO: revisit this once the bug described in
# https://github.com/spacetelescope/stsci.stimage/issues/8
# is fixed.
#
# Due to this bug minput_idx may contain duplicate values.
# Because of this, the above logic for masking, saving ids, and indices
# does not work reliably. As a workaround, we save matched array
# indices within the image catalog so that we can use them in
# `fit2ref()`. For this to work, reference and image catalog must not
# change between this function return and `fit2ref()` call.
#
self._mref_idx = mref_idx
self._minput_idx = minput_idx

And see that this reference issue is resolved upstream

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions