Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default value for PageSize when listing entries #5864

Open
sorindumitru opened this issue Feb 12, 2025 · 0 comments
Open

Add a default value for PageSize when listing entries #5864

sorindumitru opened this issue Feb 12, 2025 · 0 comments
Labels
priority/backlog Issue is approved and in the backlog

Comments

@sorindumitru
Copy link
Collaborator

Ran into the following error when calling ListEntries without a page size:

rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5064719 vs. 4194304)

It would be good if we could specify a default page size if pagination is not requested. The API says that the server can do that. Still worth considering the risks of breaking users with such a change, maybe we can start by warning that the change will be done soon?

We should probably also define some kind of maximum, derived in someway from the maximum message size.

@MarcosDY MarcosDY added the priority/backlog Issue is approved and in the backlog label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

2 participants