Skip to content

Commit 018d55c

Browse files
committed
Changes to observer
1 parent a5b8b0d commit 018d55c

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

src/androidTest/java/io/split/android/client/service/impressions/observer/ImpressionsObserverTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,23 @@ public void persistCallsPersistOnStorage() {
170170
verify(cache).persist();
171171
}
172172

173+
@Test
174+
public void previousTimeIsAlwaysNullWhenImpressionHasProperties() {
175+
ImpressionsObserver observer = new ImpressionsObserverImpl(mStorage, 1);
176+
Impression i = new Impression("key",
177+
null,
178+
"feature",
179+
"on",
180+
System.currentTimeMillis(),
181+
"label",
182+
1234567L,
183+
null,
184+
"{\"key\":\"value\"}");
185+
for (int j = 0; j < 10; j++) {
186+
assertNull(observer.testAndSet(i));
187+
}
188+
}
189+
173190
private void caller(ImpressionsObserver o, int count, ConcurrentLinkedQueue<Impression> imps) {
174191

175192
while (count-- > 0) {

src/main/java/io/split/android/client/service/impressions/observer/ImpressionsObserverImpl.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ public Long testAndSet(Impression impression) {
2727
if (null == impression) {
2828
return null;
2929
}
30+
final String properties = impression.properties();
31+
if (properties != null && !properties.isEmpty()) {
32+
return null;
33+
}
3034

3135
Long hash = ImpressionHasher.process(impression);
3236
@Nullable

0 commit comments

Comments
 (0)