Fix log message

Author: gthea

src/main/java/io/split/android/client/fallback/FallbackTreatmentsConfiguration.java

@@ -8,6 +8,7 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
+
 import io.split.android.client.utils.logger.Logger;
 
 public final class FallbackTreatmentsConfiguration {
@@ -65,6 +66,9 @@ private Builder() {
          * @return this builder instance
          */
         public Builder global(@Nullable FallbackTreatment global) {
+            if (mGlobal != null && global != null) {
+                Logger.w("Fallback treatments - You had previously set a global fallback. The new value will replace it");
+            }
             mGlobal = global;
             return this;
         }
@@ -78,6 +82,9 @@ public Builder global(@Nullable FallbackTreatment global) {
          * @return this builder instance
          */
         public Builder global(String treatment) {
+            if (mGlobal != null) {
+                Logger.w("Fallback treatments - You had previously set a global fallback. The new value will replace it");
+            }
             mGlobal = new FallbackTreatment(treatment);
             return this;
         }
@@ -99,7 +106,7 @@ public Builder byFlag(@Nullable Map<String, FallbackTreatment> byFlag) {
             for (Map.Entry<String, FallbackTreatment> e : byFlag.entrySet()) {
                 String key = e.getKey();
                 if (mByFlag.containsKey(key)) {
-                    Logger.w(getLogMessage(key));
+                    Logger.w(getDuplicateFlagMessage(key));
                 }
                 mByFlag.put(key, e.getValue());
             }
@@ -123,7 +130,7 @@ public Builder byFlagStrings(@Nullable Map<String, String> byFlag) {
             for (Map.Entry<String, String> e : byFlag.entrySet()) {
                 String key = e.getKey();
                 if (mByFlag.containsKey(key)) {
-                    Logger.w(getLogMessage(key));
+                    Logger.w(getDuplicateFlagMessage(key));
                 }
                 mByFlag.put(key, new FallbackTreatment(e.getValue()));
             }
@@ -148,8 +155,8 @@ Builder sanitizer(FallbacksSanitizer sanitizer) {
         }
 
         @NonNull
-        private static String getLogMessage(String key) {
-            return "Fallback treatments - Overriding existing fallback for flag '" + key + "' with latest value";
+        private static String getDuplicateFlagMessage(String key) {
+            return "Fallback treatments - Duplicate fallback for flag '" + key + "'. Overriding existing value.";
         }
     }
 

src/test/java/io/split/android/client/fallback/FallbackTreatmentsConfigurationTest.java

@@ -3,8 +3,8 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotEquals;
-import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
@@ -130,11 +130,10 @@ public void callingByFlagStringsAfterByFlagMergesResultsAndLogsWarning() {
         assertNull(cfg.getByFlag().get("flagA").getConfig());
         assertEquals("on", cfg.getByFlag().get("flagB").getTreatment());
         assertEquals("off", cfg.getByFlag().get("flagC").getTreatment());
-        assertNull(cfg.getByFlag().get("flagC").getConfig());
-
+        // warning logged with expected content for overridden key
         ConcurrentLinkedDeque<String> warns = printer.getLoggedMessages().get(android.util.Log.WARN);
         assertFalse("Expected at least one warning", warns.isEmpty());
-        boolean containsExpected = warns.stream().anyMatch(m -> m.contains("Overriding existing fallback for flag 'flagA'"));
+        boolean containsExpected = warns.stream().anyMatch(m -> m.contains("Fallback treatments - Duplicate fallback for flag 'flagA'. Overriding existing value."));
         assertTrue("Expected warning mentioning overridden key 'flagA'", containsExpected);
     }