Skip to content

Commit e4b9bd5

Browse files
committed
Clean up
1 parent c1f8cf3 commit e4b9bd5

2 files changed

Lines changed: 8 additions & 12 deletions

File tree

src/main/java/io/split/android/client/service/splits/SplitsSyncHelper.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,16 +239,12 @@ private SinceChangeNumbers fetchUntil(SinceChangeNumbers till, boolean clearBefo
239239

240240
TargetingRulesChange targetingRulesChange;
241241
// Try to use cached value for fresh installs
242-
if ((rbsChangeNumber == -1L) && changeNumber == -1 && mTargetingRulesCache != null) {
242+
if (rbsChangeNumber == -1L && changeNumber == -1 && mTargetingRulesCache != null) {
243243
targetingRulesChange = mTargetingRulesCache.getAndConsume();
244-
if (targetingRulesChange != null) {
245-
Logger.d("Fresh install: Using prefetched targeting rules from cache");
246-
} else {
247-
Logger.d("Fetching targeting rules - changeNumber: " + changeNumber + ", rbsChangeNumber: " + rbsChangeNumber);
244+
if (targetingRulesChange == null) {
248245
targetingRulesChange = fetchSplits(new SinceChangeNumbers(changeNumber, rbsChangeNumber), avoidCache, withCdnByPass);
249246
}
250247
} else {
251-
Logger.d("Fetching targeting rules - changeNumber: " + changeNumber + ", rbsChangeNumber: " + rbsChangeNumber);
252248
targetingRulesChange = fetchSplits(new SinceChangeNumbers(changeNumber, rbsChangeNumber), avoidCache, withCdnByPass);
253249
}
254250

src/main/java/io/split/android/client/service/splits/SplitsSyncTask.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ public static SplitTask buildForBackground(@NonNull SplitsSyncHelper splitsSyncH
4848
}
4949

5050
private SplitsSyncTask(@NonNull SplitsSyncHelper splitsSyncHelper,
51-
@NonNull SplitsStorage splitsStorage,
52-
@NonNull RuleBasedSegmentStorageProducer ruleBasedSegmentStorage,
53-
String splitsFilterQueryString,
54-
@NonNull TelemetryRuntimeProducer telemetryRuntimeProducer,
55-
@Nullable ISplitEventsManager eventsManager,
56-
int onDemandFetchBackoffMaxRetries) {
51+
@NonNull SplitsStorage splitsStorage,
52+
@NonNull RuleBasedSegmentStorageProducer ruleBasedSegmentStorage,
53+
String splitsFilterQueryString,
54+
@NonNull TelemetryRuntimeProducer telemetryRuntimeProducer,
55+
@Nullable ISplitEventsManager eventsManager,
56+
int onDemandFetchBackoffMaxRetries) {
5757

5858
mSplitsStorage = checkNotNull(splitsStorage);
5959
mSplitsSyncHelper = checkNotNull(splitsSyncHelper);

0 commit comments

Comments
 (0)