Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Update ListContainersParam filters #710

Open
johnflavin opened this issue Apr 3, 2017 · 6 comments
Open

Update ListContainersParam filters #710

johnflavin opened this issue Apr 3, 2017 · 6 comments
Labels
enhancement help wanted pinned exempt from being marked as stale

Comments

@johnflavin
Copy link
Contributor

There are lots of new filters available when listing containers. From the latest swagger.yaml:

Filters to process on the container list, encoded as JSON (a map[string][]string). For example, {"status": ["paused"]} will only return paused containers.

  • ancestor=(<image-name>[:<tag>], <image id>, or <image@digest>)
  • before=(<container id> or <container name>)
  • expose=(<port>[/<proto>]|<startport-endport>/[<proto>])
  • exited=<int> containers with exit code of <int>
  • health=(starting|healthy|unhealthy|none)
  • id=<ID> a container's ID
  • isolation=(default|process|hyperv) (Windows daemon only)
  • is-task=(true|false)
  • label=key or label="key=value" of a container label
  • name=<name> a container's name
  • network=(<network id> or <network name>)
  • publish=(<port>[/<proto>]|<startport-endport>/[<proto>])
  • since=(<container id> or <container name>)
  • status=(created|restarting|running|removing|paused|exited|dead)
  • volume=(<volume name> or <mount point destination>)

We should add these new filters. Might also be nice to dig through the older docker API documentation, figure out when each filter was added, annotate the methods with javadoc @since (docker api version).

I think this should wait on #707, which refactors all the filter params.

@albers
Copy link
Contributor

albers commented Apr 5, 2017

I also noticed some missing filters and was thinking about adding them.
I'd like to take over that task.

@davidxia
Copy link
Contributor

davidxia commented Jun 5, 2017

@johnflavin We can close this as #707 was merged, right?

@johnflavin
Copy link
Contributor Author

No, this is a different issue. #707 refactored all the existing filters to be a consistent style; its only additions were filters for networks. This issue is about adding new filters for containers.

@davidxia
Copy link
Contributor

Ah I see. PRs are welcome then :)

@stale
Copy link

stale bot commented Sep 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 24, 2018
@davidxia davidxia added pinned exempt from being marked as stale and removed stale labels Sep 24, 2018
@dmandalidis
Copy link
Contributor

Hi @albers ,

Since this project went on mature status, please re-open this issue (if it still stands) to https://github.com/dmandalidis/docker-client. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement help wanted pinned exempt from being marked as stale
Projects
None yet
Development

No branches or pull requests

4 participants