Skip to content

Commit 5844f9b

Browse files
eddumelendeztzolov
authored andcommitted
Polish Qdrant tests
Use helper methods provided by Testcontainers.
1 parent 5543643 commit 5844f9b

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

spring-ai-spring-boot-autoconfigure/src/test/java/org/springframework/ai/autoconfigure/vectorstore/qdrant/QdrantVectorStoreAutoConfigurationIT.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@
4646
@Testcontainers
4747
public class QdrantVectorStoreAutoConfigurationIT {
4848

49-
private static final int QDRANT_GRPC_PORT = 6334;
50-
5149
@Container
5250
static QdrantContainer qdrantContainer = new QdrantContainer("qdrant/qdrant:v1.9.2");
5351

@@ -59,7 +57,7 @@ public class QdrantVectorStoreAutoConfigurationIT {
5957
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
6058
.withConfiguration(AutoConfigurations.of(QdrantVectorStoreAutoConfiguration.class))
6159
.withUserConfiguration(Config.class)
62-
.withPropertyValues("spring.ai.vectorstore.qdrant.port=" + qdrantContainer.getMappedPort(QDRANT_GRPC_PORT),
60+
.withPropertyValues("spring.ai.vectorstore.qdrant.port=" + qdrantContainer.getGrpcPort(),
6361
"spring.ai.vectorstore.qdrant.host=" + qdrantContainer.getHost());
6462

6563
@Test

vector-stores/spring-ai-qdrant-store/src/test/java/org/springframework/ai/vectorstore/qdrant/QdrantVectorStoreIT.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
/**
5050
* @author Anush Shetty
5151
* @author Josh Long
52+
* @author Eddú Meléndez
5253
* @since 0.8.1
5354
*/
5455
@Testcontainers
@@ -60,8 +61,6 @@ public class QdrantVectorStoreIT {
6061

6162
private static final int EMBEDDING_DIMENSION = 1536;
6263

63-
private static final int QDRANT_GRPC_PORT = 6334;
64-
6564
@Container
6665
static QdrantContainer qdrantContainer = new QdrantContainer("qdrant/qdrant:v1.9.2");
6766

@@ -81,7 +80,7 @@ public class QdrantVectorStoreIT {
8180
static void setup() throws InterruptedException, ExecutionException {
8281

8382
String host = qdrantContainer.getHost();
84-
int port = qdrantContainer.getMappedPort(QDRANT_GRPC_PORT);
83+
int port = qdrantContainer.getGrpcPort();
8584
QdrantClient client = new QdrantClient(QdrantGrpcClient.newBuilder(host, port, false).build());
8685

8786
client
@@ -245,7 +244,7 @@ public static class TestApplication {
245244
@Bean
246245
public QdrantClient qdrantClient() {
247246
String host = qdrantContainer.getHost();
248-
int port = qdrantContainer.getMappedPort(QDRANT_GRPC_PORT);
247+
int port = qdrantContainer.getGrpcPort();
249248
QdrantClient qdrantClient = new QdrantClient(QdrantGrpcClient.newBuilder(host, port, false).build());
250249
return qdrantClient;
251250
}

0 commit comments

Comments
 (0)