Skip to content

Why are AnthropicChatOptions's getModel(), getFrequencyPenalty(), and getPresencePenalty() methods not implemented? #1546

@cowboysj

Description

@cowboysj
Contributor

In the AnthropicChatOptions class, I noticed that the getModel(), getFrequencyPenalty(), and getPresencePenalty() methods are returning null. Can you clarify why these methods are not fully implemented? Are these options not relevant to the Bedrock implementation, or are there plans to implement them in the future?
Are these features not supported by Bedrock at the moment, or are there plans to implement them internally in the near future?

models/spring-ai-bedrock/src/main/java/org/springframework/ai/bedrock/anthropic3/Anthropic3ChatOptions.java

Activity

tzolov

tzolov commented on Oct 25, 2024

@tzolov
Contributor

@cowboysj this is the old bedrock api. We are working on replacing it with the new Bedrock Converse API. But this would be limited to the fields that the Bedrock Converse and the Anthropic API. provide.

The Spring AI direct Anthropic integration, supports everything: https://docs.spring.io/spring-ai/reference/api/chat/anthropic-chat.html
and allows you to access any native anthropic options: https://docs.spring.io/spring-ai/reference/api/chat/anthropic-chat.html#_chat_properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @asaikali@tzolov@cowboysj

        Issue actions

          Why are AnthropicChatOptions's getModel(), getFrequencyPenalty(), and getPresencePenalty() methods not implemented? · Issue #1546 · spring-projects/spring-ai