Skip to content

provide setters for the various SQL queries used in the JDBC persistence types #2981

Closed
@joshlong

Description

@joshlong
Member

some of the queries that are only available as private final fields in the classes are incompatible with certain databases, like Oracle.

for example JdbcChatMemory uses a query with limit which wont work on Oracle.

There's no easy way to fix this short of copy-and-pasting the entire class and excluding Spring AI's solution. if you provide a few setters or make the queries constructor arguments, that would be sufficient to unblock

please do this for anything that uses JDBC

Activity

added this to the 1.0.0-RC1 milestone on May 3, 2025
markpollack

markpollack commented on May 9, 2025

@markpollack
Member

This has been address, the refactoring to focus on JdbcChatMemoryRepository and there isn't an impl of JdbcChatMemory anymore. PR #3037 shows how we support multiple dialects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @joshlong@markpollack

        Issue actions

          provide setters for the various SQL queries used in the JDBC persistence types · Issue #2981 · spring-projects/spring-ai